New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign: login & signup #9455
Redesign: login & signup #9455
Conversation
bad75b4
to
e244d02
Compare
e244d02
to
af99b14
Compare
af99b14
to
933223d
Compare
30b2ce4
to
6a3d923
Compare
b4a85c9
to
87a9c52
Compare
c8166e6
to
e14da07
Compare
Could you also take into consideration the UX improvements done at #9490 when implementing this? The functionality is also extracted into this module as noted in that PR: |
01bfae9
to
dab38b3
Compare
2eb3df5
to
c09ec3c
Compare
I dunno understand why the core tests are failing. They're referring to some view that it wasn't even edited. I thought it was flaky, but still returning error over and over. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me this looks overall good now and tests are passing. 👍
One more small thing I noticed, could we please fix the "jumping" effect on the form input focus states?
decidim-core/app/packs/stylesheets/decidim/_redesigned_forms.scss
Outdated
Show resolved
Hide resolved
* develop: Redesign: pages (#9457) Add "no-reply" notification at the email footers (#9668) merge layout center into one-col, allowing 3 variations (#9755) Fix form error overlap with character counter in the admin panel (#9683) Change the custom public port ENV variable name to HTTP_PORT (#9598) Redesign: login & signup (#9455) Fix redundant notification on comments with linked proposals (#9676)
@Crashillo @entantoencuanto Could you also create a "pending" issue for Login & signup please? I was reviewing some comments regarding a conference registration bugs and I realized the "invitations" view is not redesigned yet. This is the view that users are shown e.g. when you invite a new user to join a conference. I believe there are other places also where users could end up to that view, such as inviting a private space user, inviting an admin to a participatory space or inviting the first admin user to the platform after creating an organization + a couple of places in elections. |
Is this a shared view? Or the "show" (i.e. the displayed erb file) you're missing is located in conferences? Depending on that location, the pending issue tracker can be placed in Conferences itself |
@Crashillo It's a common view for all modules located at As mentioned above, Conferences is not the only place from where users can end up to that view. |
* activate redesign * login form * adapt login to new layout * extract styles login * register form * another forms of login * fix space * add placeholders & fix styles * fix button color * fix generic label css * display inline for links * password update * password hidden char * decorator size shunk * fix test login + refactor omniauth buttons * cheat tailwind compilation * append note * fix stylelint * help-text as block via CSS not HTML * fix position helper messages on login * fix admin test * fix focus border
🎩 What? Why?
Redesign login page
📌 Related Issues
This PR has built on top of #9344
📷 Screenshots