Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign: login & signup #9455

Merged
merged 23 commits into from Aug 12, 2022
Merged

Redesign: login & signup #9455

merged 23 commits into from Aug 12, 2022

Conversation

Crashillo
Copy link
Member

@Crashillo Crashillo commented Jun 21, 2022

🎩 What? Why?

Redesign login page

📌 Related Issues

This PR has built on top of #9344

📷 Screenshots

♥️ Thank you!

@Crashillo Crashillo added the contract: redesign Barcelona City Council contract label Jun 21, 2022
@Crashillo Crashillo added this to Integrating / Front in PX Redesign Jun 21, 2022
@Crashillo Crashillo changed the base branch from develop to feature/redesign-components June 21, 2022 09:38
Base automatically changed from feature/redesign-components to feature/redesign-main-layout June 21, 2022 11:44
@Crashillo Crashillo moved this from Integrating / Front to Integrating / Back in PX Redesign Jun 21, 2022
@furilo furilo moved this from Integrating / Back to Integrating / Front in PX Redesign Jun 27, 2022
@furilo furilo changed the title Redesign: login Redesign: login & signup Jun 27, 2022
Base automatically changed from feature/redesign-main-layout to feature/redesign June 29, 2022 13:17
@entantoencuanto entantoencuanto force-pushed the feature/redesign-login branch 3 times, most recently from b4a85c9 to 87a9c52 Compare July 4, 2022 19:50
Base automatically changed from feature/redesign to develop July 7, 2022 14:51
@entantoencuanto entantoencuanto force-pushed the feature/redesign-login branch 2 times, most recently from c8166e6 to e14da07 Compare July 12, 2022 15:41
@ahukkanen
Copy link
Contributor

Could you also take into consideration the UX improvements done at #9490 when implementing this?

The functionality is also extracted into this module as noted in that PR:
https://github.com/OpenSourcePolitics/decidim-module-friendly_signup

@entantoencuanto entantoencuanto force-pushed the feature/redesign-login branch 2 times, most recently from 01bfae9 to dab38b3 Compare July 21, 2022 10:12
@Crashillo Crashillo marked this pull request as ready for review July 28, 2022 14:40
@Crashillo Crashillo mentioned this pull request Aug 5, 2022
@Crashillo Crashillo mentioned this pull request Aug 10, 2022
9 tasks
@Crashillo
Copy link
Member Author

I dunno understand why the core tests are failing. They're referring to some view that it wasn't even edited. I thought it was flaky, but still returning error over and over.
@ahukkanen can we skip it?

@ahukkanen ahukkanen mentioned this pull request Aug 11, 2022
9 tasks
Copy link
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this looks overall good now and tests are passing. 👍

One more small thing I noticed, could we please fix the "jumping" effect on the form input focus states?

@ahukkanen ahukkanen merged commit 9be426d into develop Aug 12, 2022
@ahukkanen ahukkanen deleted the feature/redesign-login branch August 12, 2022 09:43
@Crashillo Crashillo moved this from Ready to Done in PX Redesign Aug 12, 2022
entantoencuanto added a commit that referenced this pull request Aug 25, 2022
* develop:
  Redesign: pages (#9457)
  Add "no-reply" notification at the email footers (#9668)
  merge layout center into one-col, allowing 3 variations (#9755)
  Fix form error overlap with character counter in the admin panel (#9683)
  Change the custom public port ENV variable name to HTTP_PORT (#9598)
  Redesign: login & signup (#9455)
  Fix redundant notification on comments with linked proposals (#9676)
@ahukkanen
Copy link
Contributor

@Crashillo @entantoencuanto Could you also create a "pending" issue for Login & signup please?

I was reviewing some comments regarding a conference registration bugs and I realized the "invitations" view is not redesigned yet. This is the view that users are shown e.g. when you invite a new user to join a conference. I believe there are other places also where users could end up to that view, such as inviting a private space user, inviting an admin to a participatory space or inviting the first admin user to the platform after creating an organization + a couple of places in elections.

@Crashillo
Copy link
Member Author

Is this a shared view? Or the "show" (i.e. the displayed erb file) you're missing is located in conferences? Depending on that location, the pending issue tracker can be placed in Conferences itself

@ahukkanen
Copy link
Contributor

@Crashillo It's a common view for all modules located at decidim-core:
https://github.com/decidim/decidim/blob/ed2587297f274d649c6455a4c45562262c66eca8/decidim-core/app/views/decidim/devise/invitations/edit.html.erb

As mentioned above, Conferences is not the only place from where users can end up to that view.

eliegaboriau pushed a commit to eliegaboriau/decidim that referenced this pull request Oct 25, 2022
* activate redesign

* login form

* adapt login to new layout

* extract styles login

* register form

* another forms of login

* fix space

* add placeholders & fix styles

* fix button color

* fix generic label css

* display inline for links

* password update

* password hidden char

* decorator size shunk

* fix test login + refactor omniauth buttons

* cheat tailwind compilation

* append note

* fix stylelint

* help-text as block via CSS not HTML

* fix position helper messages on login

* fix admin test

* fix focus border
@ahukkanen ahukkanen added the type: feature PRs or issues that implement a new feature label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract: redesign Barcelona City Council contract type: feature PRs or issues that implement a new feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants