Fix "disappearing" underscores with comments #9654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underscores were actually converted into `<em>`s which is not desired.
entantoencuanto
added a commit
that referenced
this pull request
Sep 27, 2022
* develop: Remove GIF and BMP from the default file formats (#9641) Fix webpacker crashes on missing icons (#9636) Fix exporting and importing a page component (#9638) Fix importing participatory process from legacy format (#9646) Fix the finite value on the debate form when editing an existing debate (#9645) Fix collaborative drafts page when there are errors on the form (#9656) Fix last activity page showing recently updated records (#9844) Fix date/time formats at component forms (#9632) Fix editor content saving when the content has only one video (#9629) Fix "disappearing" underscores with comments (#9654) Fix user related absolute URLs (#9596) Improve release process (#9492) Fix form answer attachments breaking the answer view (#9653) Do not import resources multiple times (#9644) Fix moderations for comments that are mapped to deleted resources (#9621) Update the CHANGELOG template and fix detailed changes heading levels (#9843)
Crashillo
pushed a commit
that referenced
this pull request
Oct 6, 2022
The underscores were actually converted into `<em>`s which is not desired.
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
The underscores were actually converted into `<em>`s which is not desired.
andreslucena
pushed a commit
that referenced
this pull request
Oct 26, 2022
The underscores were actually converted into `<em>`s which is not desired.
This was referenced Oct 26, 2022
andreslucena
pushed a commit
that referenced
this pull request
Oct 26, 2022
The underscores were actually converted into `<em>`s which is not desired.
ahukkanen
added a commit
that referenced
this pull request
Nov 1, 2022
ahukkanen
added a commit
that referenced
this pull request
Nov 3, 2022
ahukkanen
added a commit
that referenced
this pull request
Nov 8, 2022
* home accountability desktop * extract filters to component * index accountability desktop * add headers & updated sidebar widget * refactor status, mark as deprecated * extract css components * generalize drawer * use all the core assets from app-design * larger scope for stylelint overrides in gem stylesheets (not only core) * missing semicolon stylelint * home acc. mobile design * filters redesigned for mobile (also profile) * update dropdown/filters component * update filters in user_activity * enhance auto-close for dropdowns * fix erblint * move drawer to normal app * refactor list of projects * move generic metadata to css component * remove deprecated * cancel out padding right on reverse layouts * Fix global moderation types not translated (#9662) * Fix unpublished processes shown in the group process count (#9682) * Fix a typo in the logic customization manual (#9831) * Extract status to a cell * Move filter items calculation to a helper method * Fix test to not use removed stylesheets imports * Update selector in test * Fix tags selectors in tests * Fix linter offenses * Remove unused translations * Normalize translations file * add inner-button default styles * remove CSS duplicated as of 695e68a * extract css filters * Define a cell to display results data * Define a category item in result cell * Define a dates_item_compact element in result cell * Add a variant of project cell with different template and items * Allow status cell to accept models different to categories * Fix condition to build items array * Extend the use of status cell * Define linked_resources_for at cell level * Refactor results and projects views to use cells * Remove unused partials * Remove unecessary line in push notifications spec (#9833) * Fix updating organization settings in case there were errors (#9634) * Fix source format in the data consent docs for the example (#9837) * Redesign: conversations (#9469) * conversations index * conversation show * reformat scroll to bottom no jquery * fix naming * allow only one initialization on load * scroll to last child fix on reloads * conversations shows + first approach form validation no-abide * Recover form-error class in error messages in forms * Fix translations * Call author cell with context actions * Replace TODOs with REDESIGN_PENDING * Fix rubocop offense * Refactor conversations to allow creation * Recover jQuery use * Update test after abide removal * Fix tests * Allow set novalidate in decidim_form_for helper method * Recover novalidate to true by default in decidim_form_for * Move messages to controller and remove duplicated @Conversations * Validate initiative fill_data form in front * Fix typo and add validation_messages as helper_method * extract conversation styles * update markup * generalization form error * new redesign conversations * new index conversations * generalization character counter * input moji feature * fix messages layout * fix wrapper char counter * fix style issues * update conversations/new mockup * responsive aside adaptations * aside buttons conversations * reorder time in conversations * unread condition * ignore stylelint * mobile conversations * position emoji * fix position helper messages on generic forms * add character counter fix * Recover abide in forms * Fix reply js replacement after creating a conversation * Remove unused translations * Fix recovering of abide in forms * Fix selectors in tests * Recover old modal behavior * Update expected texts in tests * Hide test that may no longer be needed * Update selector in test * Update selectors in test * Comment maybe deprecated example * Remove redesign pending comments * remove redupe dep * Force id of new conversation modal form * Replace main with div in wrapper layout part This avoids accessibility errors testing redesigned parts using old layouts * tune aside layout for allow different setups in mobile * Use an identifier for main section to be used in tests * Update selector in tests looking for main * Recover main element in legacy wrapper * add css classes to shrink icon size * fix desktop sidebar layout * Extract display_name method in author cell * Hide messages button in profile actions when user has muted conversations * Display unread pending indicator in redesigned layout main links when there are unread conversations also * Enable full redesign feature in conversations integration tests * Fix tests of pending conversations * Update tests with redesigned author cell * Update tests of messages in profile * Skip temporarily accessibility tests in conversations due to pending redesign issues * Skip test pending of another PR merge to pass * Recover skipped test * Fix footer h sequence * Fix not allowed “no-external-link” on element “a” accessibility error * Replace class to hide dataconsent-warning element * Replace time with invalid value format with div * Replace invalid div inside summary with span * Add alt to image tag * Fix h sequence * Avoid having too much elements inside label tag * Remove repeated line * Recover accessibility tests in conversations * Recover move hidden class to attribute in dataconsent-warning element and fix javascript * Recover hide class for compatibility with old design * Change tag in two cols layout to ensure accessibility with old design * Add extra check * Define set_redesign using environment * Attempt to enable redesign in tests * Attempt to enable redesign in tests using configuration persisted in database * Change primary color to improve contrast * Force new commit * Force redesign_active * Redefine primary color * Disable tweak_bootsnap * Allow forcing redesign in controllers * Adapt test to parts with redesign not enabled * Revert "Force redesign_active" This reverts commit 556172c. * modal required files * conversations modal and redesigned_icon jquery-free 🎉 * Replace div tag with span to ensure accesibility * Replace div tag with span to ensure accesibility * Fix linter offense * Remove unused translation * Revert "Disable tweak_bootsnap" This reverts commit b23a400. * Prepare follow feature related tests to both redesigned and not redesigned versions * missing omniauth buttons * fix initializer multiple-mentions * fix autocomplete styles * add disabled for buttons * Add missing id * Disable automatic id * Remove deprecated tests * Skip test using old modal inside a page that will be removed * Recover hide class in condition for compatibility with old design * Remove commented code * Fix announce threshold calculation bug * Move reply form to a partial and reuse it * add i18n button title * remove autofocus * alter order buttons + shrink size * move styles to file * Fix translation alphabetical order * reduce size button modal & align center sidebar buttons * order aside actions * add border transparent to default button Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com> * Fix i18n-tasks issues * move filter search to css component * restore search element * Define a new kind of card to use for component resources in lists and create one for accountability results * Update test * Add metadata cell, use it in card_l and refactor some parts * Refactor results card_l using metadata * Update styles * Recover drawer layout * Update categories hierarchy display in filtered projects indexes * Update the CHANGELOG template and fix detailed changes heading levels (#9843) * Update the changelog template and fix detailed changes heading levels * Make the same updates to the current CHANGELOG * Fix the heading level for the API change sub sections * Add tailwind as an API change * Fix typo * Fix moderations for comments that are mapped to deleted resources (#9621) * Return nil for reported content url if the commentable is deleted * Show "deleted resource" instead of the visit URL when URL is not returned * Add system specs testing that moderations for comments with deleted resources work * Fix issue hiding comments for deleted debates * Add moderation test to hide comments for deleted resources * Add manage moderations shared examples for debates * Fix specs after merging with develop * Do not import resources multiple times (#9644) * Fix form answer attachments breaking the answer view (#9653) * Improve release process (#9492) * Improve the release related comands - Abort the process if there are uncommitted changes - Abort the process in case the official locales are not complete or clean - Do not release NPM packages in case some of the gem releases fail - Add a feature to retry the commands and make it configurable - Enable retrying the commands by default assuming using OTP authentication * Disable the GemManager retries for the generators specs * Configure retry times env variable not to retry infinitely * Configure the RETRY_TIMES env var for the gem installations in spec * Move the RETRY_TIMES configuration to the spec helper * Rubocop * Fix user related absolute URLs (#9596) * Fix the user related URLs to contain the correct port * Add a spec for the profile_url method in UserPresenter * Fix default_avatar_url in UserPresenter * Fix specs broken by the port change * Fix broken specs * Call the same method in both cases * Fix "disappearing" underscores with comments (#9654) The underscores were actually converted into `<em>`s which is not desired. * Fix editor content saving when the content has only one video (#9629) * Allow only videos on the rich text editor * Add a spec testing adding only a video through Quill * Fix date/time formats at component forms (#9632) * Fix the localized date and time with zone with ISO formats * Fix the datetime_field with Time and DateTime * Change the component time to TimeWithZone attribute type * Fix the conferences admin update controller spec * Fix last activity page showing recently updated records (#9844) * Fix last activity page showing recently updated records * Fix missing verb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Fix collaborative drafts page when there are errors on the form (#9656) * Fix the finite value on the debate form when editing an existing debate (#9645) * Fix importing participatory process from legacy format (#9646) * Fix exporting and importing a page component (#9638) * Fix webpacker crashes on missing icons (#9636) * Remove GIF and BMP from the default file formats (#9641) * Remove gif and bmp from the default allowed file formats * Remove gif from the core examples * Add results metadata in show footer * Fix argument in meetings panel * Hide progress when not present in status cell * Allow displaying status on results breadcrumb even if there are no results * Display attachments in result show (resesign pending) * Hide scope filter when component has no subscopes * hide global status from home if progress disabled in component * Update selector to work in redesigned parts * Skip test pending of redesign * Change selectors in tests * Remove not expected result in test * Add interaction to tests * Update expected content in test * Skip comments tests pending of redesign * Fix selector in test * add CSS component drawer_metadata * Remove unused argument of helper method * Add missing semicolon in scss file * Fix linter offense * Add documentation page for accessibility tips (#9608) * Add page for accessibility tips * Add the example for accessible icon links * Typo fixes and refinements * Refer to the accessibility guide from the styles customization * Document common accessibility mistakes * Valid example HTML * Generalize list styling * Add tips about headings * Fix typo * Update the page with the points from #6207 * Apply suggestions from code review Fixing typos and grammatical mistakes. Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Code review formatting Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Add a link to the data consent section at the customize index (#9828) * Add a link to the data consent section at the customize index * Add link to customize logic page Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Fix preserving bold text in the rich text editor when pasting content (#9640) * Fix editor clipboard pasting losting bold types * Add a spec testing the rich text editor clipboard pasting * Add the license notes for the Quill clipboard overrides * Fix importing a page component without a body (#9863) * Add page in AssemblyImporter JSON example * Add spec for pages imported without body * Add guard clause for pages imported without body * Fix duplicate stats on home page and participatory space main page (#9624) * Fix home page and participatory space duplicate stats * Test that there are no duplicate stats with the presenters * Remove `axe-core-rspec` dependency to get fully rid of `virtus` dependency (#9758) * Remove axe-core-rspec dependency and add a custom matcher instead In order to get rid of the `virtus` dependency, remove axe-core-rspec and replace it with a custom matcher implementing essentially the same functionality. * Rake bundle * Load the axe JS library always to make it available for the view * Do not print indented blank lines for blank messages * Add a spec for the axe matchers * Add 2 levels of indentation to the node messages To better match the output with the old format. * Fix the expected message format in the spec after changing it * Format the code slightly better * Replace social-share-button gem with social share services API (#9545) * Remove social-share-button gem * fixup! Remove social-share-button gem * Add SocialShareServiceManifest * Add social share services registry with the social networks * Add configuration in generated apps (initializer and secrets) * Add social share button helper * Add documentation * Add CHANGELOG entry for existing apps * s/Share on/Share to/g * Extract render_social_share_button to its own method * Escape URLs when sharing * Add optional params support * Fix typo * Add spec for render_social_share_button (Email and Twitter) * Refactor regexp * Remove unsupported logos for social share services * Add documentation * Fix method signature after Ruby 3 upgrade * Fix rubocop offense * Remove social-share-button gem javascript * Remove unused social services from SCSS * Remove unecessary use of the double-splat operator * Remove social-share-button gem javascript from the redesign pack * Fix issue with optional parameter value provided as nil * Resque from KeyError when calling the format method in the manifest * Do not render the social share URL if required parameters are not provided * Update the return statement documentation correctly * Add alt attribute to the social share images * Add the meta tags to the dummy resources show view In order to make the meta URL available and to show the social share buttons on the page. * Do not compact the arguments in the excape method To avoid any side-effects, compact the arguments already when passing them to the method. * Add line break at the end of the the CHANGELOG section * Fix the WhatsApp related specs in the social share button specs - Target the WhatsApp element correctly according to the new API - Remove the different cases for mobile and desktop because the new API shows the same button for both devices * Unify naming for the social media services registry and registering Use the same convention for the social media services registry as with other manifest registries. * Rubocop * Add the `DECIDIM_SOCIAL_SHARE_SERVICES` config to the env vars docs * Proofreading social shares docs * Markdownlint * Fix merge issue with CHANGELOG and add relevant section number * Run rake bundle Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi> * hide progress bar on subcategories * item-list metadata mobile * remove deprecated * no changes for design-app in accountability * remove category description * remove deprecated file * fix a11y issues * Display component name in header instead of generic accountability name * Fix path of first element of breadcrumb * upgrade heading tag * Return blank in linked_resources_for cell if no linked_resources found * Hide tabs on project cell when associated panel is blank * Add status to results card_l * Fix metadata item_list styles * new adjustment list metadata * fix icon method * Replace -> separator with - * set color progress indicator * Change scopes default icon and use resource_type_icon_key for categories and scopes Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi> Co-authored-by: Sina Eftekhar <104360479+sinaeftekhar@users.noreply.github.com> Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Crashillo
added a commit
that referenced
this pull request
Nov 10, 2022
* home accountability desktop * extract filters to component * index accountability desktop * add headers & updated sidebar widget * refactor status, mark as deprecated * extract css components * generalize drawer * use all the core assets from app-design * larger scope for stylelint overrides in gem stylesheets (not only core) * missing semicolon stylelint * home acc. mobile design * filters redesigned for mobile (also profile) * update dropdown/filters component * update filters in user_activity * enhance auto-close for dropdowns * fix erblint * move drawer to normal app * refactor list of projects * move generic metadata to css component * remove deprecated * cancel out padding right on reverse layouts * Fix global moderation types not translated (#9662) * Fix unpublished processes shown in the group process count (#9682) * Fix a typo in the logic customization manual (#9831) * Extract status to a cell * Move filter items calculation to a helper method * Fix test to not use removed stylesheets imports * Update selector in test * Fix tags selectors in tests * Fix linter offenses * Remove unused translations * Normalize translations file * add inner-button default styles * remove CSS duplicated as of 695e68a * extract css filters * Define a cell to display results data * Define a category item in result cell * Define a dates_item_compact element in result cell * Add a variant of project cell with different template and items * Allow status cell to accept models different to categories * Fix condition to build items array * Extend the use of status cell * Define linked_resources_for at cell level * Refactor results and projects views to use cells * Remove unused partials * Remove unecessary line in push notifications spec (#9833) * Fix updating organization settings in case there were errors (#9634) * Fix source format in the data consent docs for the example (#9837) * Redesign: conversations (#9469) * conversations index * conversation show * reformat scroll to bottom no jquery * fix naming * allow only one initialization on load * scroll to last child fix on reloads * conversations shows + first approach form validation no-abide * Recover form-error class in error messages in forms * Fix translations * Call author cell with context actions * Replace TODOs with REDESIGN_PENDING * Fix rubocop offense * Refactor conversations to allow creation * Recover jQuery use * Update test after abide removal * Fix tests * Allow set novalidate in decidim_form_for helper method * Recover novalidate to true by default in decidim_form_for * Move messages to controller and remove duplicated @Conversations * Validate initiative fill_data form in front * Fix typo and add validation_messages as helper_method * extract conversation styles * update markup * generalization form error * new redesign conversations * new index conversations * generalization character counter * input moji feature * fix messages layout * fix wrapper char counter * fix style issues * update conversations/new mockup * responsive aside adaptations * aside buttons conversations * reorder time in conversations * unread condition * ignore stylelint * mobile conversations * position emoji * fix position helper messages on generic forms * add character counter fix * Recover abide in forms * Fix reply js replacement after creating a conversation * Remove unused translations * Fix recovering of abide in forms * Fix selectors in tests * Recover old modal behavior * Update expected texts in tests * Hide test that may no longer be needed * Update selector in test * Update selectors in test * Comment maybe deprecated example * Remove redesign pending comments * remove redupe dep * Force id of new conversation modal form * Replace main with div in wrapper layout part This avoids accessibility errors testing redesigned parts using old layouts * tune aside layout for allow different setups in mobile * Use an identifier for main section to be used in tests * Update selector in tests looking for main * Recover main element in legacy wrapper * add css classes to shrink icon size * fix desktop sidebar layout * Extract display_name method in author cell * Hide messages button in profile actions when user has muted conversations * Display unread pending indicator in redesigned layout main links when there are unread conversations also * Enable full redesign feature in conversations integration tests * Fix tests of pending conversations * Update tests with redesigned author cell * Update tests of messages in profile * Skip temporarily accessibility tests in conversations due to pending redesign issues * Skip test pending of another PR merge to pass * Recover skipped test * Fix footer h sequence * Fix not allowed “no-external-link” on element “a” accessibility error * Replace class to hide dataconsent-warning element * Replace time with invalid value format with div * Replace invalid div inside summary with span * Add alt to image tag * Fix h sequence * Avoid having too much elements inside label tag * Remove repeated line * Recover accessibility tests in conversations * Recover move hidden class to attribute in dataconsent-warning element and fix javascript * Recover hide class for compatibility with old design * Change tag in two cols layout to ensure accessibility with old design * Add extra check * Define set_redesign using environment * Attempt to enable redesign in tests * Attempt to enable redesign in tests using configuration persisted in database * Change primary color to improve contrast * Force new commit * Force redesign_active * Redefine primary color * Disable tweak_bootsnap * Allow forcing redesign in controllers * Adapt test to parts with redesign not enabled * Revert "Force redesign_active" This reverts commit 556172c. * modal required files * conversations modal and redesigned_icon jquery-free 🎉 * Replace div tag with span to ensure accesibility * Replace div tag with span to ensure accesibility * Fix linter offense * Remove unused translation * Revert "Disable tweak_bootsnap" This reverts commit b23a400. * Prepare follow feature related tests to both redesigned and not redesigned versions * missing omniauth buttons * fix initializer multiple-mentions * fix autocomplete styles * add disabled for buttons * Add missing id * Disable automatic id * Remove deprecated tests * Skip test using old modal inside a page that will be removed * Recover hide class in condition for compatibility with old design * Remove commented code * Fix announce threshold calculation bug * Move reply form to a partial and reuse it * add i18n button title * remove autofocus * alter order buttons + shrink size * move styles to file * Fix translation alphabetical order * reduce size button modal & align center sidebar buttons * order aside actions * add border transparent to default button Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com> * Fix i18n-tasks issues * move filter search to css component * restore search element * Define a new kind of card to use for component resources in lists and create one for accountability results * Update test * Add metadata cell, use it in card_l and refactor some parts * Refactor results card_l using metadata * Update styles * Recover drawer layout * Update categories hierarchy display in filtered projects indexes * Update the CHANGELOG template and fix detailed changes heading levels (#9843) * Update the changelog template and fix detailed changes heading levels * Make the same updates to the current CHANGELOG * Fix the heading level for the API change sub sections * Add tailwind as an API change * Fix typo * Fix moderations for comments that are mapped to deleted resources (#9621) * Return nil for reported content url if the commentable is deleted * Show "deleted resource" instead of the visit URL when URL is not returned * Add system specs testing that moderations for comments with deleted resources work * Fix issue hiding comments for deleted debates * Add moderation test to hide comments for deleted resources * Add manage moderations shared examples for debates * Fix specs after merging with develop * Do not import resources multiple times (#9644) * Fix form answer attachments breaking the answer view (#9653) * Improve release process (#9492) * Improve the release related comands - Abort the process if there are uncommitted changes - Abort the process in case the official locales are not complete or clean - Do not release NPM packages in case some of the gem releases fail - Add a feature to retry the commands and make it configurable - Enable retrying the commands by default assuming using OTP authentication * Disable the GemManager retries for the generators specs * Configure retry times env variable not to retry infinitely * Configure the RETRY_TIMES env var for the gem installations in spec * Move the RETRY_TIMES configuration to the spec helper * Rubocop * Fix user related absolute URLs (#9596) * Fix the user related URLs to contain the correct port * Add a spec for the profile_url method in UserPresenter * Fix default_avatar_url in UserPresenter * Fix specs broken by the port change * Fix broken specs * Call the same method in both cases * Fix "disappearing" underscores with comments (#9654) The underscores were actually converted into `<em>`s which is not desired. * Fix editor content saving when the content has only one video (#9629) * Allow only videos on the rich text editor * Add a spec testing adding only a video through Quill * Fix date/time formats at component forms (#9632) * Fix the localized date and time with zone with ISO formats * Fix the datetime_field with Time and DateTime * Change the component time to TimeWithZone attribute type * Fix the conferences admin update controller spec * Fix last activity page showing recently updated records (#9844) * Fix last activity page showing recently updated records * Fix missing verb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Fix collaborative drafts page when there are errors on the form (#9656) * Fix the finite value on the debate form when editing an existing debate (#9645) * Fix importing participatory process from legacy format (#9646) * Fix exporting and importing a page component (#9638) * Fix webpacker crashes on missing icons (#9636) * Remove GIF and BMP from the default file formats (#9641) * Remove gif and bmp from the default allowed file formats * Remove gif from the core examples * Add results metadata in show footer * Fix argument in meetings panel * Hide progress when not present in status cell * Allow displaying status on results breadcrumb even if there are no results * Display attachments in result show (resesign pending) * Hide scope filter when component has no subscopes * hide global status from home if progress disabled in component * Update selector to work in redesigned parts * Skip test pending of redesign * Change selectors in tests * Remove not expected result in test * Add interaction to tests * Update expected content in test * Skip comments tests pending of redesign * Fix selector in test * add CSS component drawer_metadata * Remove unused argument of helper method * Add missing semicolon in scss file * Fix linter offense * Add documentation page for accessibility tips (#9608) * Add page for accessibility tips * Add the example for accessible icon links * Typo fixes and refinements * Refer to the accessibility guide from the styles customization * Document common accessibility mistakes * Valid example HTML * Generalize list styling * Add tips about headings * Fix typo * Update the page with the points from #6207 * Apply suggestions from code review Fixing typos and grammatical mistakes. Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Code review formatting Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Add a link to the data consent section at the customize index (#9828) * Add a link to the data consent section at the customize index * Add link to customize logic page Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Fix preserving bold text in the rich text editor when pasting content (#9640) * Fix editor clipboard pasting losting bold types * Add a spec testing the rich text editor clipboard pasting * Add the license notes for the Quill clipboard overrides * Fix importing a page component without a body (#9863) * Add page in AssemblyImporter JSON example * Add spec for pages imported without body * Add guard clause for pages imported without body * Fix duplicate stats on home page and participatory space main page (#9624) * Fix home page and participatory space duplicate stats * Test that there are no duplicate stats with the presenters * Remove `axe-core-rspec` dependency to get fully rid of `virtus` dependency (#9758) * Remove axe-core-rspec dependency and add a custom matcher instead In order to get rid of the `virtus` dependency, remove axe-core-rspec and replace it with a custom matcher implementing essentially the same functionality. * Rake bundle * Load the axe JS library always to make it available for the view * Do not print indented blank lines for blank messages * Add a spec for the axe matchers * Add 2 levels of indentation to the node messages To better match the output with the old format. * Fix the expected message format in the spec after changing it * Format the code slightly better * Replace social-share-button gem with social share services API (#9545) * Remove social-share-button gem * fixup! Remove social-share-button gem * Add SocialShareServiceManifest * Add social share services registry with the social networks * Add configuration in generated apps (initializer and secrets) * Add social share button helper * Add documentation * Add CHANGELOG entry for existing apps * s/Share on/Share to/g * Extract render_social_share_button to its own method * Escape URLs when sharing * Add optional params support * Fix typo * Add spec for render_social_share_button (Email and Twitter) * Refactor regexp * Remove unsupported logos for social share services * Add documentation * Fix method signature after Ruby 3 upgrade * Fix rubocop offense * Remove social-share-button gem javascript * Remove unused social services from SCSS * Remove unecessary use of the double-splat operator * Remove social-share-button gem javascript from the redesign pack * Fix issue with optional parameter value provided as nil * Resque from KeyError when calling the format method in the manifest * Do not render the social share URL if required parameters are not provided * Update the return statement documentation correctly * Add alt attribute to the social share images * Add the meta tags to the dummy resources show view In order to make the meta URL available and to show the social share buttons on the page. * Do not compact the arguments in the excape method To avoid any side-effects, compact the arguments already when passing them to the method. * Add line break at the end of the the CHANGELOG section * Fix the WhatsApp related specs in the social share button specs - Target the WhatsApp element correctly according to the new API - Remove the different cases for mobile and desktop because the new API shows the same button for both devices * Unify naming for the social media services registry and registering Use the same convention for the social media services registry as with other manifest registries. * Rubocop * Add the `DECIDIM_SOCIAL_SHARE_SERVICES` config to the env vars docs * Proofreading social shares docs * Markdownlint * Fix merge issue with CHANGELOG and add relevant section number * Run rake bundle Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi> * hide progress bar on subcategories * item-list metadata mobile * remove deprecated * no changes for design-app in accountability * remove category description * remove deprecated file * fix a11y issues * Display component name in header instead of generic accountability name * Fix path of first element of breadcrumb * upgrade heading tag * Return blank in linked_resources_for cell if no linked_resources found * Hide tabs on project cell when associated panel is blank * Add status to results card_l * Fix metadata item_list styles * new adjustment list metadata * fix icon method * Replace -> separator with - * set color progress indicator * Change scopes default icon and use resource_type_icon_key for categories and scopes Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi> Co-authored-by: Sina Eftekhar <104360479+sinaeftekhar@users.noreply.github.com> Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Quentinchampenois
pushed a commit
to Quentinchampenois/decidim
that referenced
this pull request
Nov 23, 2022
* home accountability desktop * extract filters to component * index accountability desktop * add headers & updated sidebar widget * refactor status, mark as deprecated * extract css components * generalize drawer * use all the core assets from app-design * larger scope for stylelint overrides in gem stylesheets (not only core) * missing semicolon stylelint * home acc. mobile design * filters redesigned for mobile (also profile) * update dropdown/filters component * update filters in user_activity * enhance auto-close for dropdowns * fix erblint * move drawer to normal app * refactor list of projects * move generic metadata to css component * remove deprecated * cancel out padding right on reverse layouts * Fix global moderation types not translated (decidim#9662) * Fix unpublished processes shown in the group process count (decidim#9682) * Fix a typo in the logic customization manual (decidim#9831) * Extract status to a cell * Move filter items calculation to a helper method * Fix test to not use removed stylesheets imports * Update selector in test * Fix tags selectors in tests * Fix linter offenses * Remove unused translations * Normalize translations file * add inner-button default styles * remove CSS duplicated as of 695e68a * extract css filters * Define a cell to display results data * Define a category item in result cell * Define a dates_item_compact element in result cell * Add a variant of project cell with different template and items * Allow status cell to accept models different to categories * Fix condition to build items array * Extend the use of status cell * Define linked_resources_for at cell level * Refactor results and projects views to use cells * Remove unused partials * Remove unecessary line in push notifications spec (decidim#9833) * Fix updating organization settings in case there were errors (decidim#9634) * Fix source format in the data consent docs for the example (decidim#9837) * Redesign: conversations (decidim#9469) * conversations index * conversation show * reformat scroll to bottom no jquery * fix naming * allow only one initialization on load * scroll to last child fix on reloads * conversations shows + first approach form validation no-abide * Recover form-error class in error messages in forms * Fix translations * Call author cell with context actions * Replace TODOs with REDESIGN_PENDING * Fix rubocop offense * Refactor conversations to allow creation * Recover jQuery use * Update test after abide removal * Fix tests * Allow set novalidate in decidim_form_for helper method * Recover novalidate to true by default in decidim_form_for * Move messages to controller and remove duplicated @Conversations * Validate initiative fill_data form in front * Fix typo and add validation_messages as helper_method * extract conversation styles * update markup * generalization form error * new redesign conversations * new index conversations * generalization character counter * input moji feature * fix messages layout * fix wrapper char counter * fix style issues * update conversations/new mockup * responsive aside adaptations * aside buttons conversations * reorder time in conversations * unread condition * ignore stylelint * mobile conversations * position emoji * fix position helper messages on generic forms * add character counter fix * Recover abide in forms * Fix reply js replacement after creating a conversation * Remove unused translations * Fix recovering of abide in forms * Fix selectors in tests * Recover old modal behavior * Update expected texts in tests * Hide test that may no longer be needed * Update selector in test * Update selectors in test * Comment maybe deprecated example * Remove redesign pending comments * remove redupe dep * Force id of new conversation modal form * Replace main with div in wrapper layout part This avoids accessibility errors testing redesigned parts using old layouts * tune aside layout for allow different setups in mobile * Use an identifier for main section to be used in tests * Update selector in tests looking for main * Recover main element in legacy wrapper * add css classes to shrink icon size * fix desktop sidebar layout * Extract display_name method in author cell * Hide messages button in profile actions when user has muted conversations * Display unread pending indicator in redesigned layout main links when there are unread conversations also * Enable full redesign feature in conversations integration tests * Fix tests of pending conversations * Update tests with redesigned author cell * Update tests of messages in profile * Skip temporarily accessibility tests in conversations due to pending redesign issues * Skip test pending of another PR merge to pass * Recover skipped test * Fix footer h sequence * Fix not allowed “no-external-link” on element “a” accessibility error * Replace class to hide dataconsent-warning element * Replace time with invalid value format with div * Replace invalid div inside summary with span * Add alt to image tag * Fix h sequence * Avoid having too much elements inside label tag * Remove repeated line * Recover accessibility tests in conversations * Recover move hidden class to attribute in dataconsent-warning element and fix javascript * Recover hide class for compatibility with old design * Change tag in two cols layout to ensure accessibility with old design * Add extra check * Define set_redesign using environment * Attempt to enable redesign in tests * Attempt to enable redesign in tests using configuration persisted in database * Change primary color to improve contrast * Force new commit * Force redesign_active * Redefine primary color * Disable tweak_bootsnap * Allow forcing redesign in controllers * Adapt test to parts with redesign not enabled * Revert "Force redesign_active" This reverts commit 556172c. * modal required files * conversations modal and redesigned_icon jquery-free 🎉 * Replace div tag with span to ensure accesibility * Replace div tag with span to ensure accesibility * Fix linter offense * Remove unused translation * Revert "Disable tweak_bootsnap" This reverts commit b23a400. * Prepare follow feature related tests to both redesigned and not redesigned versions * missing omniauth buttons * fix initializer multiple-mentions * fix autocomplete styles * add disabled for buttons * Add missing id * Disable automatic id * Remove deprecated tests * Skip test using old modal inside a page that will be removed * Recover hide class in condition for compatibility with old design * Remove commented code * Fix announce threshold calculation bug * Move reply form to a partial and reuse it * add i18n button title * remove autofocus * alter order buttons + shrink size * move styles to file * Fix translation alphabetical order * reduce size button modal & align center sidebar buttons * order aside actions * add border transparent to default button Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com> * Fix i18n-tasks issues * move filter search to css component * restore search element * Define a new kind of card to use for component resources in lists and create one for accountability results * Update test * Add metadata cell, use it in card_l and refactor some parts * Refactor results card_l using metadata * Update styles * Recover drawer layout * Update categories hierarchy display in filtered projects indexes * Update the CHANGELOG template and fix detailed changes heading levels (decidim#9843) * Update the changelog template and fix detailed changes heading levels * Make the same updates to the current CHANGELOG * Fix the heading level for the API change sub sections * Add tailwind as an API change * Fix typo * Fix moderations for comments that are mapped to deleted resources (decidim#9621) * Return nil for reported content url if the commentable is deleted * Show "deleted resource" instead of the visit URL when URL is not returned * Add system specs testing that moderations for comments with deleted resources work * Fix issue hiding comments for deleted debates * Add moderation test to hide comments for deleted resources * Add manage moderations shared examples for debates * Fix specs after merging with develop * Do not import resources multiple times (decidim#9644) * Fix form answer attachments breaking the answer view (decidim#9653) * Improve release process (decidim#9492) * Improve the release related comands - Abort the process if there are uncommitted changes - Abort the process in case the official locales are not complete or clean - Do not release NPM packages in case some of the gem releases fail - Add a feature to retry the commands and make it configurable - Enable retrying the commands by default assuming using OTP authentication * Disable the GemManager retries for the generators specs * Configure retry times env variable not to retry infinitely * Configure the RETRY_TIMES env var for the gem installations in spec * Move the RETRY_TIMES configuration to the spec helper * Rubocop * Fix user related absolute URLs (decidim#9596) * Fix the user related URLs to contain the correct port * Add a spec for the profile_url method in UserPresenter * Fix default_avatar_url in UserPresenter * Fix specs broken by the port change * Fix broken specs * Call the same method in both cases * Fix "disappearing" underscores with comments (decidim#9654) The underscores were actually converted into `<em>`s which is not desired. * Fix editor content saving when the content has only one video (decidim#9629) * Allow only videos on the rich text editor * Add a spec testing adding only a video through Quill * Fix date/time formats at component forms (decidim#9632) * Fix the localized date and time with zone with ISO formats * Fix the datetime_field with Time and DateTime * Change the component time to TimeWithZone attribute type * Fix the conferences admin update controller spec * Fix last activity page showing recently updated records (decidim#9844) * Fix last activity page showing recently updated records * Fix missing verb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Fix collaborative drafts page when there are errors on the form (decidim#9656) * Fix the finite value on the debate form when editing an existing debate (decidim#9645) * Fix importing participatory process from legacy format (decidim#9646) * Fix exporting and importing a page component (decidim#9638) * Fix webpacker crashes on missing icons (decidim#9636) * Remove GIF and BMP from the default file formats (decidim#9641) * Remove gif and bmp from the default allowed file formats * Remove gif from the core examples * Add results metadata in show footer * Fix argument in meetings panel * Hide progress when not present in status cell * Allow displaying status on results breadcrumb even if there are no results * Display attachments in result show (resesign pending) * Hide scope filter when component has no subscopes * hide global status from home if progress disabled in component * Update selector to work in redesigned parts * Skip test pending of redesign * Change selectors in tests * Remove not expected result in test * Add interaction to tests * Update expected content in test * Skip comments tests pending of redesign * Fix selector in test * add CSS component drawer_metadata * Remove unused argument of helper method * Add missing semicolon in scss file * Fix linter offense * Add documentation page for accessibility tips (decidim#9608) * Add page for accessibility tips * Add the example for accessible icon links * Typo fixes and refinements * Refer to the accessibility guide from the styles customization * Document common accessibility mistakes * Valid example HTML * Generalize list styling * Add tips about headings * Fix typo * Update the page with the points from decidim#6207 * Apply suggestions from code review Fixing typos and grammatical mistakes. Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Code review formatting Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Add a link to the data consent section at the customize index (decidim#9828) * Add a link to the data consent section at the customize index * Add link to customize logic page Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Fix preserving bold text in the rich text editor when pasting content (decidim#9640) * Fix editor clipboard pasting losting bold types * Add a spec testing the rich text editor clipboard pasting * Add the license notes for the Quill clipboard overrides * Fix importing a page component without a body (decidim#9863) * Add page in AssemblyImporter JSON example * Add spec for pages imported without body * Add guard clause for pages imported without body * Fix duplicate stats on home page and participatory space main page (decidim#9624) * Fix home page and participatory space duplicate stats * Test that there are no duplicate stats with the presenters * Remove `axe-core-rspec` dependency to get fully rid of `virtus` dependency (decidim#9758) * Remove axe-core-rspec dependency and add a custom matcher instead In order to get rid of the `virtus` dependency, remove axe-core-rspec and replace it with a custom matcher implementing essentially the same functionality. * Rake bundle * Load the axe JS library always to make it available for the view * Do not print indented blank lines for blank messages * Add a spec for the axe matchers * Add 2 levels of indentation to the node messages To better match the output with the old format. * Fix the expected message format in the spec after changing it * Format the code slightly better * Replace social-share-button gem with social share services API (decidim#9545) * Remove social-share-button gem * fixup! Remove social-share-button gem * Add SocialShareServiceManifest * Add social share services registry with the social networks * Add configuration in generated apps (initializer and secrets) * Add social share button helper * Add documentation * Add CHANGELOG entry for existing apps * s/Share on/Share to/g * Extract render_social_share_button to its own method * Escape URLs when sharing * Add optional params support * Fix typo * Add spec for render_social_share_button (Email and Twitter) * Refactor regexp * Remove unsupported logos for social share services * Add documentation * Fix method signature after Ruby 3 upgrade * Fix rubocop offense * Remove social-share-button gem javascript * Remove unused social services from SCSS * Remove unecessary use of the double-splat operator * Remove social-share-button gem javascript from the redesign pack * Fix issue with optional parameter value provided as nil * Resque from KeyError when calling the format method in the manifest * Do not render the social share URL if required parameters are not provided * Update the return statement documentation correctly * Add alt attribute to the social share images * Add the meta tags to the dummy resources show view In order to make the meta URL available and to show the social share buttons on the page. * Do not compact the arguments in the excape method To avoid any side-effects, compact the arguments already when passing them to the method. * Add line break at the end of the the CHANGELOG section * Fix the WhatsApp related specs in the social share button specs - Target the WhatsApp element correctly according to the new API - Remove the different cases for mobile and desktop because the new API shows the same button for both devices * Unify naming for the social media services registry and registering Use the same convention for the social media services registry as with other manifest registries. * Rubocop * Add the `DECIDIM_SOCIAL_SHARE_SERVICES` config to the env vars docs * Proofreading social shares docs * Markdownlint * Fix merge issue with CHANGELOG and add relevant section number * Run rake bundle Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi> * hide progress bar on subcategories * item-list metadata mobile * remove deprecated * no changes for design-app in accountability * remove category description * remove deprecated file * fix a11y issues * Display component name in header instead of generic accountability name * Fix path of first element of breadcrumb * upgrade heading tag * Return blank in linked_resources_for cell if no linked_resources found * Hide tabs on project cell when associated panel is blank * Add status to results card_l * Fix metadata item_list styles * new adjustment list metadata * fix icon method * Replace -> separator with - * set color progress indicator * Change scopes default icon and use resource_type_icon_key for categories and scopes Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi> Co-authored-by: Sina Eftekhar <104360479+sinaeftekhar@users.noreply.github.com> Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
ahukkanen
added a commit
that referenced
this pull request
Dec 16, 2022
* create new cells * replace hard-coded blog buttons with cells * remove externalized component from blogs * extract css component & general fixes for cells * endorsers list toggle * Refactor endorsers_list cell to inherit from RedesignedButtonCell * Refactor comments_button cell to inherit from RedesignedButtonCell * Refactor share and flag buttons to inherit from RedesignedButtonCell * Simplify redesigned button cell * share modal redesign * Remove unused translations * Fix linter offense * Split social share button and related tests in redesigned and not redesigned versions * provide social network icon colors * report button triggers flag modal * don't use an anchor if no href * identity modal * endorsement auth modals * Merge branch 'develop' into feature/redesign-action-buttons * mark old script as deprecated in jsdoc * allow remote, jquery-free modals 🎉 * Fix modal * Disable dropdown behavior if no endorsements present in endorsers list * Move remote modal initialization to redesigned_index * Include Decidim::FiltersHelper at application controller level * Split authorization modal in redesigned and legacy versions * override dropdown defaults in endorsers-list * Split authorization modal in redesigned and legacy versions * Move parts of redesigned authorizations modal content to controller * Sanitize translations * Fix linter offense * Fix tests providing redesign_enabled? method * Update tests and social_share_button_tag method * Add parameters to Dialog initializer optionally to avoid accesibility errors * Avoid blank elements in verifications of authorization modal * Ensure main tag presence in layout_center * Fix usages of `reorder` and `paginate` (#9926) * Fix organization SMTP password not saved (became blank) in system panel (#9925) * Fix organization SMTP password not saved (became blank) in system panel * Fix organization SMTP password not saved (became blank) in system panel - refactoring * Reformat CSV help for import files on Accountability and Proposals (#9891) * Move explanation in accountability's admin import CSV results We also remove the 'import-process-info' class and its CSS definition, as it isn't necessary anymore. * Add HTML support to ImportForm help text * Reformat help text to proposals' answers import * Reformat help text to proposals' import * Remove links with link word * Add nested list in explanation * Add an example for English language on i18n attributes * Refactor cell titles (#10032) * Refactor HTML escaping in cell titles * Add specs to test the cell titles * Fix meetings spec * Split CHANGELOG and RELEASE_NOTES (#10031) * Split CHANGELOG and RELEASE_NOTES to their own documents * Fix the heading levels in the changelog generator * Update releases documentation about CHANGELOG and RELEASE_NOTES * Rename to "changelog" instead of "change log" * Update the RELEASE_NOTES structure to make it easier to copy-paste * Update the RELEASE_NOTES instructions in releases documentation * Fix the previous versions link in CHANGELOG * Fix the release title * Refactor admin listing titles (#10042) * Refactor the meeting list item title display (#10043) * Refactor the meeting list item title display * Remove unnecessary method * Refactor meeting list item * Update the meeting list item spec * Add spec for the highlighted list item cell * Improve RSpec configuration (#9931) * Improve RSpec configuration * Bump version for Antora * Update the gitignore statement for development app (#10045) * Redesign: accountability (#9772) * home accountability desktop * extract filters to component * index accountability desktop * add headers & updated sidebar widget * refactor status, mark as deprecated * extract css components * generalize drawer * use all the core assets from app-design * larger scope for stylelint overrides in gem stylesheets (not only core) * missing semicolon stylelint * home acc. mobile design * filters redesigned for mobile (also profile) * update dropdown/filters component * update filters in user_activity * enhance auto-close for dropdowns * fix erblint * move drawer to normal app * refactor list of projects * move generic metadata to css component * remove deprecated * cancel out padding right on reverse layouts * Fix global moderation types not translated (#9662) * Fix unpublished processes shown in the group process count (#9682) * Fix a typo in the logic customization manual (#9831) * Extract status to a cell * Move filter items calculation to a helper method * Fix test to not use removed stylesheets imports * Update selector in test * Fix tags selectors in tests * Fix linter offenses * Remove unused translations * Normalize translations file * add inner-button default styles * remove CSS duplicated as of 695e68a * extract css filters * Define a cell to display results data * Define a category item in result cell * Define a dates_item_compact element in result cell * Add a variant of project cell with different template and items * Allow status cell to accept models different to categories * Fix condition to build items array * Extend the use of status cell * Define linked_resources_for at cell level * Refactor results and projects views to use cells * Remove unused partials * Remove unecessary line in push notifications spec (#9833) * Fix updating organization settings in case there were errors (#9634) * Fix source format in the data consent docs for the example (#9837) * Redesign: conversations (#9469) * conversations index * conversation show * reformat scroll to bottom no jquery * fix naming * allow only one initialization on load * scroll to last child fix on reloads * conversations shows + first approach form validation no-abide * Recover form-error class in error messages in forms * Fix translations * Call author cell with context actions * Replace TODOs with REDESIGN_PENDING * Fix rubocop offense * Refactor conversations to allow creation * Recover jQuery use * Update test after abide removal * Fix tests * Allow set novalidate in decidim_form_for helper method * Recover novalidate to true by default in decidim_form_for * Move messages to controller and remove duplicated @Conversations * Validate initiative fill_data form in front * Fix typo and add validation_messages as helper_method * extract conversation styles * update markup * generalization form error * new redesign conversations * new index conversations * generalization character counter * input moji feature * fix messages layout * fix wrapper char counter * fix style issues * update conversations/new mockup * responsive aside adaptations * aside buttons conversations * reorder time in conversations * unread condition * ignore stylelint * mobile conversations * position emoji * fix position helper messages on generic forms * add character counter fix * Recover abide in forms * Fix reply js replacement after creating a conversation * Remove unused translations * Fix recovering of abide in forms * Fix selectors in tests * Recover old modal behavior * Update expected texts in tests * Hide test that may no longer be needed * Update selector in test * Update selectors in test * Comment maybe deprecated example * Remove redesign pending comments * remove redupe dep * Force id of new conversation modal form * Replace main with div in wrapper layout part This avoids accessibility errors testing redesigned parts using old layouts * tune aside layout for allow different setups in mobile * Use an identifier for main section to be used in tests * Update selector in tests looking for main * Recover main element in legacy wrapper * add css classes to shrink icon size * fix desktop sidebar layout * Extract display_name method in author cell * Hide messages button in profile actions when user has muted conversations * Display unread pending indicator in redesigned layout main links when there are unread conversations also * Enable full redesign feature in conversations integration tests * Fix tests of pending conversations * Update tests with redesigned author cell * Update tests of messages in profile * Skip temporarily accessibility tests in conversations due to pending redesign issues * Skip test pending of another PR merge to pass * Recover skipped test * Fix footer h sequence * Fix not allowed “no-external-link” on element “a” accessibility error * Replace class to hide dataconsent-warning element * Replace time with invalid value format with div * Replace invalid div inside summary with span * Add alt to image tag * Fix h sequence * Avoid having too much elements inside label tag * Remove repeated line * Recover accessibility tests in conversations * Recover move hidden class to attribute in dataconsent-warning element and fix javascript * Recover hide class for compatibility with old design * Change tag in two cols layout to ensure accessibility with old design * Add extra check * Define set_redesign using environment * Attempt to enable redesign in tests * Attempt to enable redesign in tests using configuration persisted in database * Change primary color to improve contrast * Force new commit * Force redesign_active * Redefine primary color * Disable tweak_bootsnap * Allow forcing redesign in controllers * Adapt test to parts with redesign not enabled * Revert "Force redesign_active" This reverts commit 556172c. * modal required files * conversations modal and redesigned_icon jquery-free 🎉 * Replace div tag with span to ensure accesibility * Replace div tag with span to ensure accesibility * Fix linter offense * Remove unused translation * Revert "Disable tweak_bootsnap" This reverts commit b23a400. * Prepare follow feature related tests to both redesigned and not redesigned versions * missing omniauth buttons * fix initializer multiple-mentions * fix autocomplete styles * add disabled for buttons * Add missing id * Disable automatic id * Remove deprecated tests * Skip test using old modal inside a page that will be removed * Recover hide class in condition for compatibility with old design * Remove commented code * Fix announce threshold calculation bug * Move reply form to a partial and reuse it * add i18n button title * remove autofocus * alter order buttons + shrink size * move styles to file * Fix translation alphabetical order * reduce size button modal & align center sidebar buttons * order aside actions * add border transparent to default button Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com> * Fix i18n-tasks issues * move filter search to css component * restore search element * Define a new kind of card to use for component resources in lists and create one for accountability results * Update test * Add metadata cell, use it in card_l and refactor some parts * Refactor results card_l using metadata * Update styles * Recover drawer layout * Update categories hierarchy display in filtered projects indexes * Update the CHANGELOG template and fix detailed changes heading levels (#9843) * Update the changelog template and fix detailed changes heading levels * Make the same updates to the current CHANGELOG * Fix the heading level for the API change sub sections * Add tailwind as an API change * Fix typo * Fix moderations for comments that are mapped to deleted resources (#9621) * Return nil for reported content url if the commentable is deleted * Show "deleted resource" instead of the visit URL when URL is not returned * Add system specs testing that moderations for comments with deleted resources work * Fix issue hiding comments for deleted debates * Add moderation test to hide comments for deleted resources * Add manage moderations shared examples for debates * Fix specs after merging with develop * Do not import resources multiple times (#9644) * Fix form answer attachments breaking the answer view (#9653) * Improve release process (#9492) * Improve the release related comands - Abort the process if there are uncommitted changes - Abort the process in case the official locales are not complete or clean - Do not release NPM packages in case some of the gem releases fail - Add a feature to retry the commands and make it configurable - Enable retrying the commands by default assuming using OTP authentication * Disable the GemManager retries for the generators specs * Configure retry times env variable not to retry infinitely * Configure the RETRY_TIMES env var for the gem installations in spec * Move the RETRY_TIMES configuration to the spec helper * Rubocop * Fix user related absolute URLs (#9596) * Fix the user related URLs to contain the correct port * Add a spec for the profile_url method in UserPresenter * Fix default_avatar_url in UserPresenter * Fix specs broken by the port change * Fix broken specs * Call the same method in both cases * Fix "disappearing" underscores with comments (#9654) The underscores were actually converted into `<em>`s which is not desired. * Fix editor content saving when the content has only one video (#9629) * Allow only videos on the rich text editor * Add a spec testing adding only a video through Quill * Fix date/time formats at component forms (#9632) * Fix the localized date and time with zone with ISO formats * Fix the datetime_field with Time and DateTime * Change the component time to TimeWithZone attribute type * Fix the conferences admin update controller spec * Fix last activity page showing recently updated records (#9844) * Fix last activity page showing recently updated records * Fix missing verb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Fix collaborative drafts page when there are errors on the form (#9656) * Fix the finite value on the debate form when editing an existing debate (#9645) * Fix importing participatory process from legacy format (#9646) * Fix exporting and importing a page component (#9638) * Fix webpacker crashes on missing icons (#9636) * Remove GIF and BMP from the default file formats (#9641) * Remove gif and bmp from the default allowed file formats * Remove gif from the core examples * Add results metadata in show footer * Fix argument in meetings panel * Hide progress when not present in status cell * Allow displaying status on results breadcrumb even if there are no results * Display attachments in result show (resesign pending) * Hide scope filter when component has no subscopes * hide global status from home if progress disabled in component * Update selector to work in redesigned parts * Skip test pending of redesign * Change selectors in tests * Remove not expected result in test * Add interaction to tests * Update expected content in test * Skip comments tests pending of redesign * Fix selector in test * add CSS component drawer_metadata * Remove unused argument of helper method * Add missing semicolon in scss file * Fix linter offense * Add documentation page for accessibility tips (#9608) * Add page for accessibility tips * Add the example for accessible icon links * Typo fixes and refinements * Refer to the accessibility guide from the styles customization * Document common accessibility mistakes * Valid example HTML * Generalize list styling * Add tips about headings * Fix typo * Update the page with the points from #6207 * Apply suggestions from code review Fixing typos and grammatical mistakes. Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Code review formatting Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Add a link to the data consent section at the customize index (#9828) * Add a link to the data consent section at the customize index * Add link to customize logic page Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Fix preserving bold text in the rich text editor when pasting content (#9640) * Fix editor clipboard pasting losting bold types * Add a spec testing the rich text editor clipboard pasting * Add the license notes for the Quill clipboard overrides * Fix importing a page component without a body (#9863) * Add page in AssemblyImporter JSON example * Add spec for pages imported without body * Add guard clause for pages imported without body * Fix duplicate stats on home page and participatory space main page (#9624) * Fix home page and participatory space duplicate stats * Test that there are no duplicate stats with the presenters * Remove `axe-core-rspec` dependency to get fully rid of `virtus` dependency (#9758) * Remove axe-core-rspec dependency and add a custom matcher instead In order to get rid of the `virtus` dependency, remove axe-core-rspec and replace it with a custom matcher implementing essentially the same functionality. * Rake bundle * Load the axe JS library always to make it available for the view * Do not print indented blank lines for blank messages * Add a spec for the axe matchers * Add 2 levels of indentation to the node messages To better match the output with the old format. * Fix the expected message format in the spec after changing it * Format the code slightly better * Replace social-share-button gem with social share services API (#9545) * Remove social-share-button gem * fixup! Remove social-share-button gem * Add SocialShareServiceManifest * Add social share services registry with the social networks * Add configuration in generated apps (initializer and secrets) * Add social share button helper * Add documentation * Add CHANGELOG entry for existing apps * s/Share on/Share to/g * Extract render_social_share_button to its own method * Escape URLs when sharing * Add optional params support * Fix typo * Add spec for render_social_share_button (Email and Twitter) * Refactor regexp * Remove unsupported logos for social share services * Add documentation * Fix method signature after Ruby 3 upgrade * Fix rubocop offense * Remove social-share-button gem javascript * Remove unused social services from SCSS * Remove unecessary use of the double-splat operator * Remove social-share-button gem javascript from the redesign pack * Fix issue with optional parameter value provided as nil * Resque from KeyError when calling the format method in the manifest * Do not render the social share URL if required parameters are not provided * Update the return statement documentation correctly * Add alt attribute to the social share images * Add the meta tags to the dummy resources show view In order to make the meta URL available and to show the social share buttons on the page. * Do not compact the arguments in the excape method To avoid any side-effects, compact the arguments already when passing them to the method. * Add line break at the end of the the CHANGELOG section * Fix the WhatsApp related specs in the social share button specs - Target the WhatsApp element correctly according to the new API - Remove the different cases for mobile and desktop because the new API shows the same button for both devices * Unify naming for the social media services registry and registering Use the same convention for the social media services registry as with other manifest registries. * Rubocop * Add the `DECIDIM_SOCIAL_SHARE_SERVICES` config to the env vars docs * Proofreading social shares docs * Markdownlint * Fix merge issue with CHANGELOG and add relevant section number * Run rake bundle Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi> * hide progress bar on subcategories * item-list metadata mobile * remove deprecated * no changes for design-app in accountability * remove category description * remove deprecated file * fix a11y issues * Display component name in header instead of generic accountability name * Fix path of first element of breadcrumb * upgrade heading tag * Return blank in linked_resources_for cell if no linked_resources found * Hide tabs on project cell when associated panel is blank * Add status to results card_l * Fix metadata item_list styles * new adjustment list metadata * fix icon method * Replace -> separator with - * set color progress indicator * Change scopes default icon and use resource_type_icon_key for categories and scopes Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi> Co-authored-by: Sina Eftekhar <104360479+sinaeftekhar@users.noreply.github.com> Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Show only ToS acceptance when admin hasn't accepted it (#9907) * Don't show the 'Activity' card in dashboard if admin didn't accepted the ToS * Don't show the 'Global moderations' menu if admin didn't accepted the ToS * Extract spec to a shared example * Don't show the 'Participants' menu if admin didn't accepted the ToS * Fix CTA button copy * Don't show the 'Templates' menu if admin didn't accepted the ToS * Don't show the 'Initiatives' menu if admin didn't accepted the ToS * Add system spec * Fix specs * Add example for ToS acceptance in 'Global moderations' * Fix spec * Add example for ToS acceptance in 'Space moderations' * Fix guard clause when admin is managing users * Fix usages of sanitize helper methods for editable content provided by admins (#10007) * Fix usages of sanitize helper methods for editable content provided by admins. Related issue: #9927 Fixes usages of sanitize for `description` of `ParticipatoryProcess` and `ParticipatoryProcessGroup`. * Fix usages of sanitize for `description` of assembly, conference and voting. Unify spec test. * Fix usages of sanitize for `short_description` of conference. * Always allow image upload in WYSWYG editor (#10011) * Disable editor_images option in WYSWYG editor * Correct rubocop offenses * shared html styles for modals * move action button to the right if it's the only child * this block removal is within 38ac609, but it would contains conflicts to cherrypick it * modal resposive refactor * update modals markup * fix share modal mobile * refactor conversations modal * fix stylelint * change social share manifest attribute * Call renamed attribute correctly * limit the scope of th einitializer js function * limit scope of frame-render initializer * Remove redesigned_flag_modal from layout * Move flag modal to report_button cell * Make blog posts reportable * fix erblint * Add initial value to some functions and fix references to document * standarize jsdoc * fix social icon name * Fix partial to include class in div conditionally * add documentation for social share setup * close modals on click outside * keep modal focus * Recover old options in redesign_authorized_to * Use button instead of link in redesigned_follow_button * Remove not required translation * Replace endorse with like in button * Remove report button from blog posts * Revert reportable concern inclusion in blog posts This reverts partially commit eb76be2. * Make cache_hash private in report button * add copy text to button * add id to trigger button endorsement cell * Move authorizations modal to a cell * handle external link warning modal * Fix expected button texts on endosement tests * Use link processed by controller instead of using param directly * Remove unused translation * Disable temporarily test after redesign * replace modal warning if already exists * don't use rails helper on simple view * remove deprecated helper * Clarify comment * hide button if no endorsements * button translations * show the plus indicator conditionally * toggle icons like/dislike * move icon keys to icon_helper * fix debates test * Update decidim-blogs/config/locales/en.yml Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * replace identity list with a11y code * remove no necessary * Define a cell to wrap the block of endorsers and endorse button * Move content of endorse button to a partial inside cell * Define action to refresh endorse button content and endorsers list * Use default implementation for comments button * Define function in js.erb only if redesign is enabled to avoid errors * handle remote modals special case * fix linter * short line * fix fix fix * Fix linter offense * iterate over children with no variable mutation * Don't display dialog modal trigger if remote_url blank * add button to the remote loader * clearer buttons * Set nil as default for method in redesigned_button cell * replace all available h3 dialog with h2 * add tabindex by default to titles * set focus on title & better handling remote-modals * Avoid initialize twice on turbo events * dont show svg on hover/focus * Change selector to identify like button * Update whole like button if user doesn't have to select an identity * Extract part of cell to template * Display elements of endorsers button and list even when there are no endorsers * wrap text into a span for truncate purposes Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com> Co-authored-by: Sergei Krylov <sergei.krylov@yahoo.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi> Co-authored-by: Sina Eftekhar <104360479+sinaeftekhar@users.noreply.github.com> Co-authored-by: Fernando Blat <fernando@blat.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Some underscores are "disappearing" with Decidim comments as described at #9394. Well it turns out they are not actually disappearing but replaced with
<em>s during the Redcarpet markdown parsing which is probably not desired functionality for Decidim as can be seen e.g. from this bug.I also tried the
:no_intra_emphasisoption provided by Redcarpet but it's not working properly, so I just decided to disable the functionality altogether.📌 Related Issues
Testing
Try posting the example comment from #9394 and see whether it is rendered correctly.