Backport 'Fix account update without password change' to v0.27 #9735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Handle password change properly at the account form When the user tried to update their account without changing their password, they could not submit the form due to the front-end validations. Fix this issue by marking those fields required only when they are visible on the form. * Make sure the spec checks the encrypted password is not changed When account is updated without providing a password, the encrypted password shouldn't change. * Do not autofill the password on the account form In tests, the user record responds to which causes the account form updates to work differently in tests than they do for actual users. * Apply feedback from the code review * Add also password and password confirmation errors on the form In case the password update failed, the user doesn't get any feedback. This fixes that issue.
ahukkanen
added
backport
andreslucena
approved these changes
Sep 12, 2022
andreslucena
deleted the
backport/0.27/fix-account-update-without-pas-9582
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
Backport #9582 to v0.27