Backport 'Fix uninitialized constant errors with custom set of modules' to v0.27 #9743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix uninitialized constant errors for unexisting modules * Add specs for the dependency resolver * Document the method without documentation * Remove unnecessary commented code * DRY comments * Reset the resolver cache during the tests * Add debug messages for CI * More debug * Try relative paths to the git gems in the custom Gemfile * Print out the generated Gemfile.lock * Revert "Try relative paths to the git gems in the custom Gemfile" This reverts commit bb2f675. * Print out the root dirs in the test debug * Revert "Print out the root dirs in the test debug" This reverts commit 06983f1. * Move debug to its own spec * Print out bundle(r) and gem related ENV vars * More debug logging * Remove the unnecessary yield argument * Fix syntax error * Add debug for the dummy lockfile generation * Report bundle not frozen during the custom Gemfile specs * Remove the debug output from the custom Gemfile specs * Add specs for * Add missing return value YARD docs * Rubocop auto-correct
ahukkanen
added
backport
|
@ahukkanen there's a git conflict, probably generated by the last set of merges. Can you check it out please? Thanks |
…ed-constant-err-9577
|
@andreslucena Done. |
andreslucena
approved these changes
Sep 12, 2022
andreslucena
deleted the
backport/0.27/fix-uninitialized-constant-err-9577
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Backport #9577 to v0.27