Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 'Fix order when filtering Meetings' to v0.26 #9751

Merged
merged 5 commits into from Sep 12, 2022
Merged

Backport 'Fix order when filtering Meetings' to v0.26 #9751

merged 5 commits into from Sep 12, 2022

Conversation

ahukkanen
Copy link
Contributor

馃帺 What? Why?

Backport #9683 to v0.26

鈾ワ笍 Thank you!

andreslucena and others added 5 commits August 15, 2022 17:58
@andreslucena @ahukkanen
Fix order when filtering Meetings (#9505)
7fac48e 
* Change date meetings filters checkboxes to radio buttons

* Fix default upcoming filter on meetings' controller

* Order filtered meetings by start_time

* Use Faker::Date in meetings' seeds

* Convert let definitions to one line blocks

* Fix typo

* Add default filter specs for Upcoming meetings

* Add specs for 'date filters' on meetings

* Reintroduces the 'All' filter for meetings dates

* Remove uneceessary instance variable

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>

* Fix for 500 errors on static maps

* Preserve the currently selected per_page value with filter forms

* Fix the broken specs due to changes in the per_page configuration

* Do not use concat in helpers that are used in cells

* Rubocop

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
@ahukkanen
Use the correct legacy search API in 0.26
2e1667a
@ahukkanen
Do not use the per_page filter as it is not relevant in 0.26
4f5bd4a
@ahukkanen
Target the correct search element in 0.26
5e8a4c0
@ahukkanen
Fix the share URL dialog after filtering the view
38c358a
@ahukkanen ahukkanen added module: meetings backport Pull Requests that are a backport for a fixed bug type: fix PRs that implement a fix for a bug labels Aug 15, 2022
@ahukkanen
Copy link
Contributor Author

ahukkanen commented Aug 15, 2022 •
edited

Notes for reviewer:

andreslucena
andreslucena approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done some quick frontend check for this one just to be extra sure. Seems like everything is as expected.

@andreslucena andreslucena merged commit 3095f97 into release/0.26-stable Sep 12, 2022
@andreslucena andreslucena deleted the backport/0.26/fix-order-when-filtering-meeti-9505 branch September 12, 2022 09:58
@alecslupu alecslupu added this to the 0.26.3 milestone Jul 14, 2023
@alecslupu alecslupu mentioned this pull request Jul 19, 2023
Open
@paulinebessoles paulinebessoles mentioned this pull request Oct 5, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreslucena andreslucena andreslucena approved these changes

Assignees
No one assigned
Labels
backport Pull Requests that are a backport for a fixed bug module: meetings type: fix PRs that implement a fix for a bug
Projects
None yet
Milestone
0.26.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahukkanen @andreslucena @alecslupu