Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds documentation in the README about how to provide FB credentials #112

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Conversation

esilvert
Copy link
Contributor

Hello everyone,

Using FCM I've come across the same issue as #110.
We are a bit confused about how to pass the firebase credentials safely from an ENV variable.

Digging around the lib, I've found two things:

  1. The limitation of passing a file path to FCM comes from googleauth gem that requires a json_key_io responding to #read (source).
  2. This lib is clever enough to use any IO responding to #read as credentials instead of a file path

Only thing is that the usage of an IO is a bit hidden in the test suite here or in the codebase here.

So here I am suggesting adding a small part about it in the readme.

Feel free to ask for a rewording or more details.

@sabman sabman merged commit 40eb6ef into decision-labs:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants