Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is neighbours_distance ? #168

Closed
BedirhanKeskin opened this issue Mar 31, 2022 · 5 comments
Closed

What is neighbours_distance ? #168

BedirhanKeskin opened this issue Mar 31, 2022 · 5 comments

Comments

@BedirhanKeskin
Copy link

Hello,
What is the neighbours_distance and difference with the distance definition inside Lidar?
They are inside MULTI_AGENT_METADRIVE_DEFAULT_CONFIG
I guess the unit is in meters?
``
Ekran görüntüsü 2022-03-31 114715

@pengzhenghao
Copy link
Member

Hi @BedirhanKeskin ,

neighbours_distance is nothing to do with Lidar and it is in fact not used at all in native MetaDrive!

It is used in other work, namely one of our previous paper and it is nothing to do with Lidar. Maybe we should remove it to avoid confusion.

Thanks!

@pengzhenghao
Copy link
Member

Oh though we should probably not discuss it here, I remember you are working on Multi-agent MetaDrive and please make sure to pull latest MetaDrive. This is because we recently identify a bug that might hurt multi-agent training. See #161 for details. Thanks!

@BedirhanKeskin
Copy link
Author

BedirhanKeskin commented Mar 31, 2022

Thank you!!
Then the distance argument parameter inside the lidar dictionary affects other_v_info data acquired from lidarObserver, doesn't it?
Also, What does the 40 mean there exactly?

Best Regards,

@pengzhenghao
Copy link
Member

Then the distance argument parameter inside the lidar dictionary affects other_v_info data acquired from lidarObserver, doesn't it?

That's correct.

Also, What does the 40 mean there exactly?

The Lidar module will send (by default) 240 lasers, all centered at current ego vehicle's center. Each this laser has 40 meters length at most if it does not shot any object. Otherwise the laser has the length = distance to nearest obstacle.

The Lidar module will return a 240-dim vector, rescaled to [0, 1] but has the physical range [0, 40m], representing the shortest distance to the obstacle at the corresponding direction at each angle.

Note that in MARL env, the number of lasers is 70.

@BedirhanKeskin
Copy link
Author

Thanks for the great explanation!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants