Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more description for Waymo dataset #225

Closed
wants to merge 7 commits into from
Closed

Add more description for Waymo dataset #225

wants to merge 7 commits into from

Conversation

pengzhenghao
Copy link
Member

What changes do you make in this PR?

  • Please describe why you create this PR

Checklist

  • I have merged the latest main branch into current branch.
  • I have run bash scripts/format.sh before merging.
  • Please use "squash and merge" mode.

@pengzhenghao
Copy link
Member Author

@QuanyiLi

I find we need to update more information on how to use Waymo dataset.

First, we need to update drive_in_waymo_env.py file since it does not include information on how to download and put to where of the waymo dataset.

Second, the read_data_from_dataset.rst file in document need to be update.

Thanks!

@pengzhenghao
Copy link
Member Author

WAYMO_ENV_CONFIG = dict(
    # ===== Map Config =====
    waymo_data_directory=AssetLoader.file_path("waymo", return_raw_style=False),
    start_case_index=0,
    case_num=100,
    store_map=True,

    # ===== Traffic =====
    no_traffic=False,
    traj_start_index=0,
    traj_end_index=-1,
    replay=True,
    no_static_traffic_vehicle=False,

    # ===== Agent config =====
    vehicle_config=dict(
        lidar=dict(num_lasers=120, distance=50),
        lane_line_detector=dict(num_lasers=12, distance=50),
        side_detector=dict(num_lasers=120, distance=50)
    ),
    use_waymo_observation=True,

    # ===== Reward Scheme =====
    # See: https://github.com/metadriverse/metadrive/issues/283
    success_reward=10.0,
    out_of_road_penalty=10.0,
    crash_vehicle_penalty=10.0,
    crash_object_penalty=1.0,
    driving_reward=1.0,
    speed_reward=0.1,
    use_lateral_reward=False,
    horizon=500,

    # ===== Cost Scheme =====
    crash_vehicle_cost=1.0,
    crash_object_cost=1.0,
    out_of_road_cost=1.0,

    # ===== Termination Scheme =====
    out_of_route_done=False,
    crash_vehicle_done=True,
)

We have so many config here, I think we need more docs to describe what they are doing

@pengzhenghao
Copy link
Member Author

I also find that WaymoEnv has many overlap with MetaDriveEnv. Maybe we should merge them?

@pengzhenghao
Copy link
Member Author

I remove some config since it seems nobody is using them. Again, WaymoEnv Config need more docs

@pengzhenghao
Copy link
Member Author

??

@QuanyiLi
Copy link
Member

QuanyiLi commented Nov 7, 2022

Do NOT merge them. When we call MetaDriveEnv, it is synthetic data env using PG/rules. Despite some overlapping content, inheriting from BaseEnv allows a better decomposition.

@QuanyiLi QuanyiLi deleted the waymo branch August 29, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants