Non-Blocking Examples and Tests #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
deckerego
commented
Jan 14, 2023
deckerego
commented
- Removed timeouts & waits to allow for nonblocking mode
- Tests for socket connection OSErrors
- Example for nonblocking mode
- Associated unit tests
Adapted from the circuitpython webserver Co-authored-by: Ran Katz <rkatz@apple.com>
…for nonblocking mode
|
@nightmechanic - I merged in the changes you suggested as part of #25 without adding a "poll" mode, instead you can set the socket as "nonblocking" and do other work in the background. See the examples folder for how I tested things out on the ESP32-S2. |
|
Thanks a lot, and sorry for not following up, been too busy with work etc. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.