Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Can't upgrade Stencil in apps, prerendering build fails and duplicates pages in the DOM #675

Closed
3 tasks done
peterpeterparker opened this issue Mar 23, 2020 · 2 comments · Fixed by #724
Closed
3 tasks done

Can't upgrade Stencil in apps, prerendering build fails and duplicates pages in the DOM #675

peterpeterparker opened this issue Mar 23, 2020 · 2 comments · Fixed by #724
Labels
bug Something isn't working dependencies Pull requests that update a dependency file docs Documentation remote Remote control studio "Studio" is the codename for the web editor
Milestone
v1.4.0

Comments

@peterpeterparker
Copy link
Contributor

peterpeterparker commented Mar 23, 2020 •
edited

Affected part of DeckDeckGo

  • Studio
  • Remote control
  • Documentation

Reproduction

Build fails: ionic-team/stencil#2301

Duplicate pages in the DOM: ionic-team/stencil#2366
@peterpeterparker peterpeterparker added bug Something isn't working docs Documentation remote Remote control studio "Studio" is the codename for the web editor dependencies Pull requests that update a dependency file labels Mar 23, 2020
@peterpeterparker peterpeterparker changed the title Can't upgrade Stencil in apps, prerendering build is failing Can't upgrade Stencil in apps, prerendering build is failing and duplicating pages in the DOM Apr 13, 2020
@peterpeterparker
Copy link
Contributor Author

--prerender removed from remote. Reinject once solved (as we are blocked there).

@peterpeterparker peterpeterparker changed the title Can't upgrade Stencil in apps, prerendering build is failing and duplicating pages in the DOM Can't upgrade Stencil in apps, prerendering build fails and duplicates pages in the DOM Apr 13, 2020
@peterpeterparker peterpeterparker added this to the v1.1.0 milestone Apr 19, 2020
peterpeterparker added a commit that referenced this issue May 8, 2020
@peterpeterparker
feat(#675): setAttributeNode isn't supported by Stencil prerendering
a7639b4 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue May 8, 2020
@peterpeterparker
release(#675): youtube v1.1.1 and demo v1.0.3
18d66fa 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue May 8, 2020
@peterpeterparker
Merge pull request #722 from deckgo/prerendering-frame
bf5f9a6 
feat(#675): prerendering frame setAttributeNode
peterpeterparker added a commit that referenced this issue May 8, 2020
@peterpeterparker
release(#675): drr component for prerendering
9da5284 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue May 8, 2020
@peterpeterparker
release(#675): split template for prerendering
98c4e4c 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue May 8, 2020
@peterpeterparker
Merge pull request #723 from deckgo/prerender-component
fa5ef8d 
feat(#675): prerender component
@peterpeterparker peterpeterparker modified the milestones: v1.1.0, v1.2.0 May 8, 2020
@peterpeterparker peterpeterparker linked a pull request May 10, 2020 that will close this issue
fix(#675): prerendering #724
Merged
@peterpeterparker peterpeterparker modified the milestones: v1.2.0, v1.3.0 May 14, 2020
peterpeterparker added a commit that referenced this issue May 14, 2020
@peterpeterparker
feat(#675): uncomment prerender for the time being
bffddfa 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
@peterpeterparker peterpeterparker modified the milestones: v1.3.0, v1.4.0 May 28, 2020
@peterpeterparker peterpeterparker mentioned this issue Jun 10, 2020
Closed
@peterpeterparker
Copy link
Contributor Author

The prerendering issue itself should be closed but we can't upgrade right now because of a rollup related error ionic-team/stencil#2461

peterpeterparker added a commit that referenced this issue Jun 25, 2020
@peterpeterparker
feat(#675): update stencil v1.15 to solve prerendering
474ca90 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Jun 25, 2020
@peterpeterparker
feat(#675): update stencil v1.15 to solve prerendering
641304d 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Jun 25, 2020
@peterpeterparker
feat(#675): update stencil v1.15 to solve prerendering
b36bc49 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Jun 25, 2020
@peterpeterparker
fix(#675): generate sw hash for prerendering
edb05ec 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Jun 25, 2020
@peterpeterparker
fix(#675): update firebase
a7dc0f3 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Jun 25, 2020
@peterpeterparker
fix(#675): flash. hide ion-app until root load
c92c438 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Jun 25, 2020
@peterpeterparker
fix(#675): flash. hide ion-app until root load
3f67bae 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Jun 25, 2020
@peterpeterparker
fix(#675): flash. hide ion-app until root load
47cd32a 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Jun 25, 2020
@peterpeterparker
style(#675): padding with prerendering
e2cb7f4 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Jun 25, 2020
@peterpeterparker
release(#675): docs v1.6.0
7f460c9 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Jun 25, 2020
@peterpeterparker
release(#675): remote v1.4.0
defb2e4 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Jun 25, 2020
@peterpeterparker
release(#675): studio v1.4.0
d4c87cb 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Jun 25, 2020
@peterpeterparker
Merge pull request #724 from deckgo/fix-prerender
86b9dd7 
fix(#675): prerendering
peterpeterparker added a commit that referenced this issue Jun 25, 2020
@peterpeterparker
fix(#675): firebase storage object not defined
e2ef148 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file docs Documentation remote Remote control studio "Studio" is the codename for the web editor
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

fix(#675): prerendering deckgo/deckdeckgo
1 participant
@peterpeterparker