Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Transform white-space to a CSS in deckdeckgo/highlight-code #707

Closed
1 task done
peterpeterparker opened this issue Apr 23, 2020 · 5 comments · Fixed by #709
Closed
1 task done

Transform white-space to a CSS in deckdeckgo/highlight-code #707

peterpeterparker opened this issue Apr 23, 2020 · 5 comments · Fixed by #709
Assignees
@williamkwao
Labels
enhancement New feature or request good first issue Good for newcomers highlight-code Highlight code web component
Milestone
v1.1.0

Comments

@peterpeterparker
Copy link
Contributor

peterpeterparker commented Apr 23, 2020 •
edited
Loading

Affected part of DeckDeckGo

  • Web Components

Feature Description

Request provided by @williamkwao in deckgo/gatsby-remark-highlight-code#7

Another feature that I think will be nice to have is the ability to pass a CSS or config var that will enable library users to set the white-space property of the code block in the shadow dom. The code currently wraps and I'll prefer it to have a horizontal scroll. I know this one might require a some changes in @deckdeckgo/highlight-code web component.
@peterpeterparker peterpeterparker added enhancement New feature or request good first issue Good for newcomers highlight-code Highlight code web component labels Apr 23, 2020
@peterpeterparker peterpeterparker mentioned this issue Apr 23, 2020
Closed
@williamkwao
Copy link
Contributor

Thanks, @peterpeterparker! I'll start working on this.

@peterpeterparker
Copy link
Contributor Author

Sweet @williamkwao 👍

Ping me if you have any questions

@peterpeterparker peterpeterparker changed the title Transform white-space to a CSS in deckdeckgo/highlich-code Transform white-space to a CSS in deckdeckgo/highlight-code Apr 24, 2020
@peterpeterparker
Copy link
Contributor Author

PS.: The component is there in our monorepo -> https://github.com/deckgo/deckdeckgo/tree/master/webcomponents/highlight-code

williamkwao added a commit to williamkwao/deckdeckgo that referenced this issue Apr 25, 2020
@williamkwao
highlight-code(deckgo#707) make code white-space a css variable
763a4b2
@williamkwao williamkwao mentioned this issue Apr 25, 2020
Merged
7 tasks
peterpeterparker added a commit that referenced this issue Apr 26, 2020
@peterpeterparker
Merge pull request #709 from williamkwao/dev
3bafff5 
highlight-code(#707) make code white-space a css variable
@peterpeterparker peterpeterparker linked a pull request Apr 26, 2020 that will close this issue
highlight-code(#707) make code white-space a css variable #709
Merged
7 tasks
@peterpeterparker
Copy link
Contributor Author

Nice!

I have released a new version of both the component and the related Gatsby plugin, doing so your two PRs should be now available.

Thx a lot @williamkwao 👍

@peterpeterparker peterpeterparker added this to the v1.1.0 milestone Apr 26, 2020
@williamkwao
Copy link
Contributor

Thanks! Will definitely look for more opportunities to contribute

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamkwao williamkwao

Labels
enhancement New feature or request good first issue Good for newcomers highlight-code Highlight code web component
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

highlight-code(#707) make code white-space a css variable williamkwao/deckdeckgo
2 participants
@williamkwao @peterpeterparker