This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
Add basic vertical split functionality #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
- Add Prop() `vertical` to DeckdeckgoSlideSplit
- Append attribute `-vertical` to slide classes `deckgo-slide` and `deckgo-slide-split`
- Add and extend `deckgo-slide-vertical` and `deckgo-slide-split-vertical` styles:
- `deckgo-slide-vertical`
- flex-flow is `column wrap`
- height is slide height - bottom paddings * 2: `calc(var(--slide-height) - (2 * var(--slide-split-padding-bottom, var(--slide-padding-bottom-default))))`
- `deckgo-slide-split-vertical`
- width is slide width - end & start paddings: `calc(var(--slide-width) - (var(--slide-split-padding-end, var(--slide-padding-end-default))) - (var(--slide-split-padding-start, var(--slide-padding-start-default))));`
|
@timrodz thx for the PR 👍 I tested it in the demo and the Therefore I suggest the following improvements:
in order to not override the default
If you are agree, could you plz update your PR with these? Thx 🙏 Screenshots before these changes:
Screenshot after changes:
|
|
@peterpeterparker Thanks for the suggestions, will action these! |
1. Remove height override in `div.deckgo-slide-vertical` 2. Add height override to `div.deckgo-slide-split-vertical`
peterpeterparker
added
enhancement
|
Perfect and awesome @timrodz 👍 |
|
Thanks for the great guidance, @peterpeterparker! This project is great. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
verticalto DeckdeckgoSlideSplit-verticalto slide classesdeckgo-slideanddeckgo-slide-splitdeckgo-slide-verticalanddeckgo-slide-split-verticalstyles:deckgo-slide-verticalcolumn wrapcalc(var(--slide-height) - (2 * var(--slide-split-padding-bottom, var(--slide-padding-bottom-default))))deckgo-slide-split-verticalcalc(var(--slide-width) - (var(--slide-split-padding-end, var(--slide-padding-end-default))) - (var(--slide-split-padding-start, var(--slide-padding-start-default))));Closes #372 🚀