Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openvpn] Set default value for loadbalancer object in the OpenAPI schema #1353

Merged
merged 2 commits into from
Apr 13, 2022
Merged

[openvpn] Set default value for loadbalancer object in the OpenAPI schema #1353

merged 2 commits into from
Apr 13, 2022

Conversation

vitaliy-sn
Copy link
Member

@vitaliy-sn vitaliy-sn commented Apr 13, 2022 •
edited by z9r5

Description

Set default value for loadbalancer object in the OpenAPI schema

Why do we need it, and what problem does it solve?

This fixes a bug in the OpenAPI schema that occurs when using the LoadBalancer inlet.

Changelog entries

section: openvpn
type: fix
summary: Set default value for loadbalancer object in the OpenAPI schema.

@vitaliy-sn vitaliy-sn self-assigned this Apr 13, 2022
@vitaliy-sn vitaliy-sn force-pushed the openvpn-fix-nil-lb-annotations branch from b392832 to e83377c Compare April 13, 2022 10:06
@z9r5 z9r5 added this to the v1.32.2 milestone Apr 13, 2022
@z9r5 z9r5 added the type/bug label Apr 13, 2022
@z9r5 z9r5 changed the title [openvpn] set default for loadbalancer object in openapi [openvpn] Set default value for loadbalancer object in the OpenAPI schema Apr 13, 2022
zuzzas
zuzzas previously requested changes Apr 13, 2022
View reviewed changes
ee/fe/modules/500-openvpn/openapi/config-values.yaml Outdated Show resolved Hide resolved
@nabokihms nabokihms added the skip/documentation-validation Skip documentation validation in pull request label Apr 13, 2022
@z9r5 z9r5 merged commit cf011a7 into main Apr 13, 2022
@z9r5 z9r5 deleted the openvpn-fix-nil-lb-annotations branch April 13, 2022 10:45
This was referenced Apr 13, 2022
Merged
Closed
z9r5 pushed a commit that referenced this pull request Apr 13, 2022
@vitaliy-sn @z9r5
[openvpn] Set default value for loadbalancer object in the OpenAPI sc…
20a0f22 
…hema (#1353)

[openvpn] set default for loadbalancer object in the OpenAPI schema

Co-authored-by: Maksim Nabokikh <maksim.nabokikh@flant.com>
(cherry picked from commit cf011a7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabokihms nabokihms nabokihms approved these changes

@zuzzas zuzzas zuzzas left review comments

Assignees

@vitaliy-sn vitaliy-sn

Labels
skip/documentation-validation Skip documentation validation in pull request type/bug
Projects
None yet
Milestone
v1.32.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vitaliy-sn @zuzzas @nabokihms @z9r5