[cni-cilium] Fixed value modifying hook #1575
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a hook so it won't ever return nil.
Why do we need it, and what problem does it solve?
We rely on this value in Helm templates:
Error: helm upgrade failed: error validating \"\": error validating data: unknown object type \"nil\" in ConfigMap.data.auto-direct-node-routes\n"
.The error was introduced via a last-minute change in the original Cilium PR that removed defaulting in OpenAPI.
Changelog entries