Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[candi] Enable GracefulNodeShutdown flag on k8s 1.20 #1777

Merged
merged 1 commit into from Jun 15, 2022
Merged

[candi] Enable GracefulNodeShutdown flag on k8s 1.20 #1777

merged 1 commit into from Jun 15, 2022

Conversation

zuzzas
Copy link
Contributor

@zuzzas zuzzas commented Jun 14, 2022 •
edited by z9r5

Description

Feature gate was not enabled on Kubernetes 1.20.

Why do we need it, and what problem does it solve?

Kubelet did not start on Kubernetes 1.20.

Changelog entries

section: candi
type: fix
summary: Enabled the `GracefulNodeShutdown` flag on K8s 1.20 to fix kubelet not starting.

@zuzzas zuzzas added type/bug area/cluster-and-infrastructure Pull requests that update infra modules e2e/use/k8s/1.26 Use Kubernetes 1.26 for e2e tests labels Jun 14, 2022
@zuzzas zuzzas added this to the v1.33.4 milestone Jun 14, 2022
@zuzzas zuzzas self-assigned this Jun 14, 2022
@nabokihms nabokihms added status/backport Backport pr e2e/run/yandex-cloud Run e2e tests in Yandex Cloud labels Jun 14, 2022
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Jun 14, 2022 •
edited

🔴 e2e: Yandex.Cloud for deckhouse:enable-graceful-shutdown-feature-gate-k8s-1.20 failed in 14m13s.

Workflow details (1 job failed)

🔴 e2e: Yandex.Cloud, Containerd, Kubernetes 1.20 failed in 12m18s.

@github-actions github-actions bot removed the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Jun 14, 2022
RomanenkoDenys
RomanenkoDenys previously approved these changes Jun 14, 2022
View reviewed changes
@zuzzas
[candi] Enable GracefulNodeShutdown flag on kis 1.20
aded711 
Signed-off-by: Andrey Klimentyev <andrey.klimentyev@flant.com>
@zuzzas zuzzas force-pushed the enable-graceful-shutdown-feature-gate-k8s-1.20 branch from 0c0d9fd to aded711 Compare June 15, 2022 09:15
@zuzzas zuzzas added the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Jun 15, 2022
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Jun 15, 2022 •
edited

🔴 e2e: Yandex.Cloud for deckhouse:enable-graceful-shutdown-feature-gate-k8s-1.20 failed in 1h0m25s.

Workflow details (1 job failed)

🔴 e2e: Yandex.Cloud, Containerd, Kubernetes 1.20 failed in 49m49s.

@github-actions github-actions bot removed the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Jun 15, 2022
@zuzzas
Copy link
Contributor Author

zuzzas commented Jun 15, 2022

@nabokihms
It's failing on

ModuleRun failed in phase 'CanRunHelm'. Requeue task to retry after delay. Failed count is 188. Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(Prometheus.spec.alerting): missing required field "alertmanagers" in com.coreos.monitoring.v1.Prometheus.spec.alerting

I think you can merge that now.

@zuzzas zuzzas requested a review from nabokihms June 15, 2022 10:03
@nabokihms nabokihms merged commit bebd19b into main Jun 15, 2022
@nabokihms nabokihms deleted the enable-graceful-shutdown-feature-gate-k8s-1.20 branch June 15, 2022 10:19
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Jun 15, 2022
Merged
z9r5 pushed a commit that referenced this pull request Jun 16, 2022
@zuzzas @z9r5
[candi] Enable GracefulNodeShutdown flag on kis 1.20 (#1777)
0d11db2 
Signed-off-by: Andrey Klimentyev <andrey.klimentyev@flant.com>
(cherry picked from commit bebd19b)
@z9r5 z9r5 removed the status/backport Backport pr label Jun 16, 2022
@z9r5
Copy link
Member

z9r5 commented Jun 16, 2022

Cherry-picked into release-1.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabokihms nabokihms nabokihms approved these changes

@RomanenkoDenys RomanenkoDenys RomanenkoDenys left review comments

@konstantin-axenov konstantin-axenov Awaiting requested review from konstantin-axenov

Assignees

@zuzzas zuzzas

Labels
area/cluster-and-infrastructure Pull requests that update infra modules e2e/use/k8s/1.26 Use Kubernetes 1.26 for e2e tests type/bug
Projects
None yet
Milestone
v1.33.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zuzzas @deckhouse-BOaTswain @z9r5 @nabokihms @RomanenkoDenys