Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cloud-provider-vsphere] fix error in terraform for static nodes in s… #1785

Merged
merged 3 commits into from Jun 15, 2022
Merged

[cloud-provider-vsphere] fix error in terraform for static nodes in s… #1785

merged 3 commits into from Jun 15, 2022

Conversation

RomanenkoDenys
Copy link
Member

@RomanenkoDenys RomanenkoDenys commented Jun 14, 2022 •
edited by z9r5

…etups without nested resource pools

Signed-off-by: Denis Romanenko denis.romanenko@flant.com

Description

Fix error in terraform for static nodes in setups without nested resource pools.

Why do we need it, and what problem does it solve?

Changelog entries

section: cloud-provider-vsphere
type: fix
summary: Fix error in Terraform for static nodes in setups without nested resource pools.

@RomanenkoDenys RomanenkoDenys added the area/cloud-provider Pull requests that update cloud providers modules label Jun 14, 2022
@RomanenkoDenys RomanenkoDenys added this to the v1.33.4 milestone Jun 14, 2022
@RomanenkoDenys RomanenkoDenys self-assigned this Jun 14, 2022
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Jun 14, 2022 •
edited

🔴 e2e: vSphere for deckhouse:fix-terraform-vsphere failed in 16m26s.

Workflow details (1 job failed)

🔴 e2e: vSphere for deckhouse:fix-terraform-vsphere failed in 57s.

Workflow details (1 job failed)

🔴 e2e: vSphere, Containerd, Kubernetes 1.21 failed in 18s.

⏩ `e2e: vSphere, Containerd, Kubernetes 1.21` for `deckhouse:fix-terraform-vsphere` [started](https://github.com/deckhouse/deckhouse/actions/runs/2495060792).

🔴 e2e: vSphere, Containerd, Kubernetes 1.21 failed in 11s.

@github-actions github-actions bot removed the e2e/run/vsphere Run e2e tests in vSphere label Jun 14, 2022
@RomanenkoDenys RomanenkoDenys added the e2e/run/vsphere Run e2e tests in vSphere label Jun 14, 2022
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Jun 14, 2022 •
edited

🔴 e2e: vSphere for deckhouse:fix-terraform-vsphere failed in 31m20s.

Workflow details (1 job failed)

🔴 e2e: vSphere, Containerd, Kubernetes 1.21 failed in 30m38s.

@github-actions github-actions bot removed the e2e/run/vsphere Run e2e tests in vSphere label Jun 14, 2022
@RomanenkoDenys RomanenkoDenys added the e2e/run/vsphere Run e2e tests in vSphere label Jun 14, 2022
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Jun 14, 2022 •
edited

🔴 e2e: vSphere for deckhouse:fix-terraform-vsphere failed in 31m42s.

Workflow details (1 job failed)

🔴 e2e: vSphere, Containerd, Kubernetes 1.21 failed in 30m26s.

@github-actions github-actions bot removed the e2e/run/vsphere Run e2e tests in vSphere label Jun 14, 2022
@RomanenkoDenys RomanenkoDenys added the e2e/run/vsphere Run e2e tests in vSphere label Jun 14, 2022
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Jun 14, 2022 •
edited

🔴 e2e: vSphere for deckhouse:fix-terraform-vsphere failed in 31m23s.

Workflow details (1 job failed)

🔴 e2e: vSphere, Containerd, Kubernetes 1.21 failed in 30m42s.

@github-actions github-actions bot removed the e2e/run/vsphere Run e2e tests in vSphere label Jun 14, 2022
@RomanenkoDenys RomanenkoDenys added the e2e/run/vsphere Run e2e tests in vSphere label Jun 14, 2022
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Jun 14, 2022 •
edited

🔴 e2e: vSphere for deckhouse:fix-terraform-vsphere failed in 1h14m6s.

Workflow details (1 job failed)

🔴 e2e: vSphere, Containerd, Kubernetes 1.21 failed in 1h13m27s.

@github-actions github-actions bot removed the e2e/run/vsphere Run e2e tests in vSphere label Jun 14, 2022
@RomanenkoDenys
[cloud-provider-vsphere] fix error in terraform for static nodes in s…
270515c 
…etups without nested resource pools

Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
@RomanenkoDenys
[cloud-provider-vsphere] fix error in terraform for static nodes in s…
d7f1c56 
…etups without nested resource pools

Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
@RomanenkoDenys
[cloud-provider-vsphere] fix error in terraform for static nodes in s…
0cff719 
…etups without nested resource pools

Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
@RomanenkoDenys RomanenkoDenys added the e2e/run/vsphere Run e2e tests in vSphere label Jun 14, 2022
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Jun 14, 2022 •
edited

🟢 e2e: vSphere for deckhouse:fix-terraform-vsphere succeeded in 34m17s.

Workflow details

🟢 e2e: vSphere, Containerd, Kubernetes 1.21 succeeded in 33m38s.

@github-actions github-actions bot removed the e2e/run/vsphere Run e2e tests in vSphere label Jun 14, 2022
@nabokihms nabokihms merged commit c75a774 into main Jun 15, 2022
@nabokihms nabokihms deleted the fix-terraform-vsphere branch June 15, 2022 05:24
@nabokihms nabokihms added the status/backport Backport pr label Jun 15, 2022
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Jun 15, 2022
Merged
z9r5 pushed a commit that referenced this pull request Jun 16, 2022
@RomanenkoDenys @z9r5
[cloud-provider-vsphere] fix error in terraform for static nodes in s…
2331840 
…etups without nested resource pools (#1785)

Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>

(cherry picked from commit c75a774)
Signed-off-by: Artem Kladov <artem.kladov@flant.com>
@z9r5 z9r5 removed the status/backport Backport pr label Jun 16, 2022
@z9r5
Copy link
Member

z9r5 commented Jun 16, 2022

Cherry-picked into release-1.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabokihms nabokihms nabokihms approved these changes

Assignees

@RomanenkoDenys RomanenkoDenys

Labels
area/cloud-provider Pull requests that update cloud providers modules
Projects
None yet
Milestone
v1.33.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RomanenkoDenys @deckhouse-BOaTswain @z9r5 @nabokihms