Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deckhouse] improve deckhouse update process #1851

Merged
merged 4 commits into from Jun 24, 2022
Merged

[deckhouse] improve deckhouse update process #1851

merged 4 commits into from Jun 24, 2022

Conversation

yalosev
Copy link
Member

@yalosev yalosev commented Jun 22, 2022 •
edited by z9r5

Description

Suspend only pending releases. Apply first release automatically on deckhouse bootstrap

Why do we need it, and what problem does it solve?

Improve update process. Suspending deployed release leads to implicit behavior. Also as first pending release

Changelog entries

section: deckhouse
type: feature
summary: Automatically apply the first release on Deckhouse bootstrap.

@yalosev yalosev self-assigned this Jun 22, 2022
@yalosev yalosev requested a review from nabokihms June 22, 2022 20:08
@yalosev yalosev added the status/backport Backport pr label Jun 23, 2022
@yalosev
suspend only pending release
0dbdd9f 
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
@yalosev
Apply first release while bootstrapping
43ff5cd 
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
@yalosev
handle registry with port
b5190a8 
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
@yalosev
comment
7cd37e3 
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
@yalosev yalosev requested a review from nabokihms June 24, 2022 09:51
nabokihms
nabokihms requested changes Jun 24, 2022
View reviewed changes
Copy link
Member

@nabokihms nabokihms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry. The one comment is still left.

nabokihms
nabokihms approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@nabokihms nabokihms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed it internally and agreed that the solution is ok for the particular case.

@nabokihms nabokihms merged commit 0c124e9 into main Jun 24, 2022
@nabokihms nabokihms deleted the improve-deckhouse-update branch June 24, 2022 14:03
@yalosev yalosev added this to the v1.33.9 milestone Jun 24, 2022
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Jun 26, 2022
Merged
z9r5 pushed a commit that referenced this pull request Jun 27, 2022
@yalosev @z9r5
[deckhouse] improve deckhouse update process (#1851)
7b1622b 
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
(cherry picked from commit 0c124e9)
@z9r5 z9r5 removed the status/backport Backport pr label Jun 27, 2022
@z9r5
Copy link
Member

z9r5 commented Jun 27, 2022

Cherry-picked into release-1.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabokihms nabokihms nabokihms approved these changes

Assignees

@yalosev yalosev

Labels
None yet
Projects
None yet
Milestone
v1.33.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yalosev @z9r5 @nabokihms