Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[monitoring-kubernetes] node-exporter: parse containerd config #1866

Merged
merged 10 commits into from Jun 27, 2022
Merged

[monitoring-kubernetes] node-exporter: parse containerd config #1866

merged 10 commits into from Jun 27, 2022

Conversation

yalosev
Copy link
Member

@yalosev yalosev commented Jun 24, 2022 •
edited by z9r5

Signed-off-by: Yuriy Losev yuriy.losev@flant.com

Description

Managed clusters (EKS, Yandex, GKE) with deckhouse as module couldn't work with kubelet-eviction-threshold-exporter because they don't have crictl and also socket can have different passes. But all of them have /etc/containerd/config.toml, so we can parse it and extract root direction

Why do we need it, and what problem does it solve?

kubelet-eviction-threshold-exporter doesn't work in platform managed kubernetes.

kubelet-eviction-threshold-exporter /bin/loop: line 33: crictl: command not found

Changelog entries

section: monitoring-kubernetes
type: fix
summary: Make the `kubelet-eviction-threshold-exporter` workable in managed Kubernetes platforms (AWS, GKE, Yandex, etc).

@yalosev
parse containerd config
80a83fe 
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
@yalosev yalosev self-assigned this Jun 24, 2022
@yalosev yalosev changed the title parse containerd config [monitoring-kubernetes] node-exporter: parse containerd config Jun 24, 2022
@yalosev
hm
57f6264 
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
@yalosev
alpine 3.15
242fa6f 
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
@yalosev
cp
f62910f 
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
@yalosev
add debug command
1deff6f 
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
@yalosev
add debug command
0659541 
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
@yalosev yalosev added the status/backport Backport pr label Jun 24, 2022
@yalosev yalosev added this to the v1.33.9 milestone Jun 24, 2022
@yalosev yalosev marked this pull request as ready for review June 24, 2022 14:42
@yalosev yalosev requested a review from nabokihms as a code owner June 24, 2022 14:42
nabokihms
nabokihms previously approved these changes Jun 25, 2022
View reviewed changes
Copy link
Member

@nabokihms nabokihms left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like Denys to also have a look on this PR, yet it lgtm.

modules/340-monitoring-kubernetes/images/kubelet-eviction-thresholds-exporter/loop Outdated Show resolved Hide resolved
@yalosev
copyright
747ecf6 
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
@yalosev
remove dasel use bash
e1639e7 
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
@yalosev
restore alpine
2deba0a 
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
RomanenkoDenys
RomanenkoDenys previously approved these changes Jun 27, 2022
View reviewed changes
@nabokihms nabokihms added the area/monitoring Pull requests that update monitoring modules label Jun 27, 2022
nabokihms
nabokihms previously approved these changes Jun 27, 2022
View reviewed changes
@yalosev
config path
e684b6e 
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
@yalosev yalosev dismissed stale reviews from nabokihms and RomanenkoDenys via e684b6e June 27, 2022 10:17
@nabokihms nabokihms added the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Jun 27, 2022
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Jun 27, 2022 •
edited

🟢 e2e: Yandex.Cloud for deckhouse:containerd-exporter succeeded in 31m54s.

Workflow details

🟢 e2e: Yandex.Cloud, Containerd, Kubernetes 1.21 succeeded in 31m18s.

@github-actions github-actions bot removed the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Jun 27, 2022
@nabokihms nabokihms merged commit b61984e into main Jun 27, 2022
@nabokihms nabokihms deleted the containerd-exporter branch June 27, 2022 11:32
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Jun 27, 2022
Merged
z9r5 pushed a commit that referenced this pull request Jun 27, 2022
@yalosev @z9r5
[monitoring-kubernetes] node-exporter: parse containerd config (#1866)
4f7f6d2 
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
(cherry picked from commit b61984e)
@z9r5
Copy link
Member

z9r5 commented Jun 27, 2022

Cherry-picked into release-1.33

@z9r5 z9r5 removed the status/backport Backport pr label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabokihms nabokihms nabokihms approved these changes

@RomanenkoDenys RomanenkoDenys RomanenkoDenys left review comments

Assignees

@yalosev yalosev

Labels
area/monitoring Pull requests that update monitoring modules
Projects
None yet
Milestone
v1.33.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yalosev @deckhouse-BOaTswain @z9r5 @nabokihms @RomanenkoDenys