Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node-manager] added VPA for early-oom daemonset #2695

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Conversation

RomanenkoDenys
Copy link
Member

@RomanenkoDenys RomanenkoDenys commented Oct 9, 2022

Signed-off-by: Denis Romanenko denis.romanenko@flant.com

Description

Added VPA for early-oom daemonset.

Why do we need it, and what problem does it solve?

Previously early-oom has static resources requests and limits(and requests = limits). On big nodes (>100 cpu) early-oom pod needs more cpu than allowed by limit. Standard solution - use VPA to calculate requests based on real cpu usage.

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: node-manager
type: fix
summary: Added VPA for early-oom daemonset.

Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
@RomanenkoDenys RomanenkoDenys added the area/cluster-and-infrastructure Pull requests that update infra modules label Oct 9, 2022
@RomanenkoDenys RomanenkoDenys added this to the v1.37.4 milestone Oct 9, 2022
@RomanenkoDenys RomanenkoDenys self-assigned this Oct 9, 2022
@RomanenkoDenys RomanenkoDenys added e2e/run/gcp Run e2e tests in Google Cloud e2e/use/k8s/1.23 labels Oct 9, 2022
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Oct 9, 2022

🟢 e2e: GCP for deckhouse:early-oom-vpa succeeded in 27m22s.

Workflow details

🟢 e2e: GCP, Containerd, Kubernetes 1.23 succeeded in 26m42s.

@github-actions github-actions bot removed the e2e/run/gcp Run e2e tests in Google Cloud label Oct 9, 2022
@apolovov apolovov merged commit 2e6f6fa into main Oct 10, 2022
@apolovov apolovov deleted the early-oom-vpa branch October 10, 2022 09:38
@z9r5 z9r5 added the status/backport Backport pr label Oct 10, 2022
github-actions bot pushed a commit that referenced this pull request Oct 10, 2022
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
@deckhouse-BOaTswain
Copy link
Collaborator

Cherry pick PR 2703 to the branch release-1.37 successful!

deckhouse-BOaTswain added a commit that referenced this pull request Oct 10, 2022
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>

Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
Co-authored-by: Denys Romanenko <65756796+RomanenkoDenys@users.noreply.github.com>
@deckhouse-BOaTswain deckhouse-BOaTswain removed the status/backport Backport pr label Oct 10, 2022
This was referenced Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-and-infrastructure Pull requests that update infra modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants