Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prometheus] fix disk retention size calc #2825

Merged
merged 2 commits into from
Oct 24, 2022
Merged

[prometheus] fix disk retention size calc #2825

merged 2 commits into from
Oct 24, 2022

Conversation

vitaliy-sn
Copy link
Member

@vitaliy-sn vitaliy-sn commented Oct 24, 2022 •
edited by z9r5

Signed-off-by: Vitaliy Snurnitsin vitaliy.snurnitsin@flant.com

Description

  • Fixed disk retention size calculation for small disks.
  • Added tests for disks smaller than the default size.

Why do we need it, and what problem does it solve?

This fixes a bug.

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: prometheus
type: fix
summary: Fixed disk retention size calculation for small disks.

@vitaliy-sn
[prometheus] fix disk retention size calc
6cb3ad0 
Signed-off-by: Vitaliy Snurnitsin <vitaliy.snurnitsin@flant.com>
@vitaliy-sn
go
1787c3b 
Signed-off-by: Vitaliy Snurnitsin <vitaliy.snurnitsin@flant.com>
@vitaliy-sn vitaliy-sn self-assigned this Oct 24, 2022
@vitaliy-sn vitaliy-sn added area/monitoring Pull requests that update monitoring modules type/bug labels Oct 24, 2022
@z9r5 z9r5 added this to the v1.38.1 milestone Oct 24, 2022
@konstantin-axenov konstantin-axenov added e2e/run/gcp Run e2e tests in Google Cloud e2e/use/cri/containerd labels Oct 24, 2022
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Oct 24, 2022 •
edited

🟢 e2e: GCP for deckhouse:prometheus-retention-calc-fix succeeded in 27m11s.

Workflow details

🟢 e2e: GCP, Containerd, Kubernetes 1.23 succeeded in 26m31s.

@github-actions github-actions bot removed the e2e/run/gcp Run e2e tests in Google Cloud label Oct 24, 2022
@yalosev yalosev self-requested a review October 24, 2022 09:27
@name212 name212 requested review from name212 and removed request for yalosev October 24, 2022 09:27
@vitaliy-sn vitaliy-sn removed the request for review from konstantin-axenov October 24, 2022 09:33
@z9r5 z9r5 added the status/backport Backport pr label Oct 24, 2022
@z9r5 z9r5 merged commit 13bfec0 into main Oct 24, 2022
@z9r5 z9r5 deleted the prometheus-retention-calc-fix branch October 24, 2022 09:59
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Oct 24, 2022
Merged
github-actions bot pushed a commit that referenced this pull request Oct 24, 2022
@vitaliy-sn @z9r5
[prometheus] fix disk retention size calc (#2825)
5ef02c6 
Signed-off-by: Vitaliy Snurnitsin <vitaliy.snurnitsin@flant.com>
@deckhouse-BOaTswain
Copy link
Collaborator

Cherry pick PR 2826 to the branch release-1.38 successful!

deckhouse-BOaTswain added a commit that referenced this pull request Oct 24, 2022
@deckhouse-BOaTswain @vitaliy-sn
[prometheus] fix disk retention size calc (#2825) (#2826)
8520f47 
Signed-off-by: Vitaliy Snurnitsin <vitaliy.snurnitsin@flant.com>

Signed-off-by: Vitaliy Snurnitsin <vitaliy.snurnitsin@flant.com>
Co-authored-by: vitaliy-sn <32643620+vitaliy-sn@users.noreply.github.com>
@deckhouse-BOaTswain deckhouse-BOaTswain removed the status/backport Backport pr label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yalosev yalosev yalosev approved these changes

Assignees

@vitaliy-sn vitaliy-sn

Labels
area/monitoring Pull requests that update monitoring modules type/bug
Projects
None yet
Milestone
v1.38.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vitaliy-sn @deckhouse-BOaTswain @yalosev @z9r5 @konstantin-axenov