Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[yandex-cloud-provider] Fix. Add additionalExternalNetworkIDs config in openapi spec #361

Merged
merged 1 commit into from
Dec 13, 2021
Merged

[yandex-cloud-provider] Fix. Add additionalExternalNetworkIDs config in openapi spec #361

merged 1 commit into from
Dec 13, 2021

Conversation

name212
Copy link
Member

@name212 name212 commented Dec 10, 2021 •
edited by z9r5

Description

When we refactored yandex-cloud-provider module we forgot to add additionalExternalNetworkIDs in OpenAPI spec.

Why do we need it and what problem does it solve?

Deckhouse does not converge

Changelog entries

module: yandex-cloud-provider
type: fix
description: Add `additionalExternalNetworkIDs` config in OpenAPI spec, because Deckhouse does not converge if this field exists in a cluster.

@name212 name212 added area/cloud-provider Pull requests that update cloud providers modules area/network Pull requests that update cni and network modules type/bug labels Dec 10, 2021
@name212 name212 self-assigned this Dec 10, 2021
@name212
Copy link
Member Author

name212 commented Dec 10, 2021

Need for 1.28

@z9r5 z9r5 added this to the v1.29.0 milestone Dec 10, 2021
nabokihms
nabokihms previously approved these changes Dec 10, 2021
View reviewed changes
@nabokihms nabokihms self-requested a review December 13, 2021 12:54
@nabokihms nabokihms merged commit 65de93a into main Dec 13, 2021
@nabokihms nabokihms deleted the nm-fix-yandex branch December 13, 2021 15:03
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Dec 13, 2021
Merged
@z9r5 z9r5 modified the milestones: v1.29.0, v1.28.0 Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabokihms nabokihms nabokihms approved these changes

Assignees

@name212 name212

Labels
area/cloud-provider Pull requests that update cloud providers modules area/network Pull requests that update cni and network modules type/bug
Projects
None yet
Milestone
v1.28.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@name212 @nabokihms @z9r5