Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[user-authn] Custom login screen design #4305

Merged
merged 3 commits into from
Apr 5, 2023
Merged

[user-authn] Custom login screen design #4305

merged 3 commits into from
Apr 5, 2023

Conversation

nabokihms
Copy link
Member

@nabokihms nabokihms commented Apr 5, 2023 •
edited by z9r5

Description

Customize design

Why do we need it, and what problem does it solve?

image

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: user-authn
type: feature
summary: Custom login screen design.

@nabokihms
[user-authn] Custom login screen design
201cbf7 
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
@nabokihms nabokihms requested a review from apolovov April 5, 2023 14:20
@nabokihms nabokihms added this to the v1.45.0 milestone Apr 5, 2023
@nabokihms
[user-authn] Fix bugs
962fb40 
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
@nabokihms nabokihms force-pushed the user-authn-dex-custom-design branch from 58145e2 to 962fb40 Compare April 5, 2023 14:22
@nabokihms nabokihms added area/auth Pull requests that update auth modules skip/no-cyrillic-validation Skip Cyrillic letters validation in pull request labels Apr 5, 2023
apolovov
apolovov previously approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@apolovov apolovov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤗

RomanenkoDenys
RomanenkoDenys previously approved these changes Apr 5, 2023
View reviewed changes
@nabokihms nabokihms marked this pull request as ready for review April 5, 2023 14:37
@nabokihms nabokihms added the e2e/run/gcp Run e2e tests in Google Cloud label Apr 5, 2023
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Apr 5, 2023 •
edited

🟢 e2e: GCP for deckhouse:user-authn-dex-custom-design succeeded in 28m3s.

Workflow details

GCP-WithoutNAT-Containerd-1.23 - Connection string: ssh user@34.159.250.215

🟢 e2e: GCP, Containerd, Kubernetes 1.23 succeeded in 27m24s.

@github-actions github-actions bot removed the e2e/run/gcp Run e2e tests in Google Cloud label Apr 5, 2023
@nabokihms
[user-authn] Fix devices
0a0607f 
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
@nabokihms nabokihms dismissed stale reviews from RomanenkoDenys and apolovov via 0a0607f April 5, 2023 22:10
@nabokihms nabokihms merged commit a2c89ca into main Apr 5, 2023
27 checks passed
@nabokihms nabokihms deleted the user-authn-dex-custom-design branch April 5, 2023 22:25
This was referenced Apr 5, 2023
Merged
Merged
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apolovov apolovov apolovov left review comments

@RomanenkoDenys RomanenkoDenys RomanenkoDenys left review comments

Assignees
No one assigned
Labels
area/auth Pull requests that update auth modules skip/no-cyrillic-validation Skip Cyrillic letters validation in pull request
Projects
None yet
Milestone
v1.45.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nabokihms @deckhouse-BOaTswain @apolovov @RomanenkoDenys