Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[upmeter] Limit agent serviceaccount to access only required resources #469

Merged
merged 1 commit into from Dec 27, 2021
Merged

[upmeter] Limit agent serviceaccount to access only required resources #469

merged 1 commit into from Dec 27, 2021

Conversation

shvgn
Copy link
Contributor

@shvgn shvgn commented Dec 21, 2021 •
edited

Description

Fixes all-mighty access rights

Why we need it and what problem does it solve?

Fixes #169

Changelog entries

module: upmeter
type: fix
description: Assigned limited access rights to the agent serviceaccount

@shvgn shvgn requested a review from nabokihms December 21, 2021 17:29
@shvgn shvgn added area/monitoring Pull requests that update monitoring modules area/security Pull requests that update security modules type/bug and removed type/bug labels Dec 21, 2021
@shvgn shvgn marked this pull request as ready for review December 23, 2021 19:28
@nabokihms nabokihms added this to the v1.30.0 milestone Dec 24, 2021
nabokihms
nabokihms approved these changes Dec 24, 2021
View reviewed changes
Copy link
Member

@nabokihms nabokihms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

@konstantin-axenov konstantin-axenov merged commit a1e30bc into main Dec 27, 2021
@konstantin-axenov konstantin-axenov deleted the upmeter-agent-rbac branch December 27, 2021 14:15
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Dec 27, 2021
Merged
@shvgn shvgn changed the title Limit agent serviceaccount to access only required resources [upmeter] Limit agent serviceaccount to access only required resources Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabokihms nabokihms nabokihms approved these changes

@konstantin-axenov konstantin-axenov Awaiting requested review from konstantin-axenov

Assignees

@shvgn shvgn

Labels
area/monitoring Pull requests that update monitoring modules area/security Pull requests that update security modules
Projects
None yet
Milestone
v1.30.0
Development

Successfully merging this pull request may close these issues.

[upmeter] Limit agent serviceaccount to access only required resources
3 participants
@shvgn @nabokihms @konstantin-axenov