Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm] Fix deprecated k8s resources metrics #4751

Merged
merged 2 commits into from May 24, 2023

Conversation

alex123012
Copy link
Contributor

@alex123012 alex123012 commented May 24, 2023

Description

Fix deprecated k8s resources metrics

Why do we need it, and what problem does it solve?

There are some mistakes in deprecated resources config

Why do we need it in the patch release (if we do)?

There are some mistakes in deprecated resources config, that are in k8s version 1.25, which we start to support in deckhouse v1.42

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: helm
type: fix
summary: Fix deprecated k8s resources metrics.
impact_level: default

+
Signed-off-by: alexey.makhonin <alexey.makhonin@flant.com>
@alex123012 alex123012 added this to the v1.47.0 milestone May 24, 2023
@alex123012 alex123012 self-assigned this May 24, 2023
Copy link
Member

@yalosev yalosev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add deprecated resources for kubernetes 1.29 please.
https://kubernetes.io/docs/reference/using-api/deprecation-guide/#removed-apis-by-release

@yalosev yalosev modified the milestones: v1.47.0, v1.45.11 May 24, 2023
+
Signed-off-by: alexey.makhonin <alexey.makhonin@flant.com>
@yalosev yalosev merged commit 5e62542 into main May 24, 2023
26 of 27 checks passed
@yalosev yalosev deleted the helm-fix-deprecated-api-versions branch May 24, 2023 19:59
@yalosev yalosev added the status/backport Backport pr label May 24, 2023
github-actions bot pushed a commit that referenced this pull request May 24, 2023
Signed-off-by: alexey.makhonin <alexey.makhonin@flant.com>
@deckhouse-BOaTswain
Copy link
Collaborator

Cherry pick PR 4756 to the branch release-1.45 successful!

deckhouse-BOaTswain added a commit that referenced this pull request May 24, 2023
Signed-off-by: alexey.makhonin <alexey.makhonin@flant.com>
Co-authored-by: Makhonin Alexey <60808275+alex123012@users.noreply.github.com>
@deckhouse-BOaTswain deckhouse-BOaTswain removed the status/backport Backport pr label May 24, 2023
@yalosev
Copy link
Member

yalosev commented May 24, 2023

/backport v1.46

github-actions bot pushed a commit that referenced this pull request May 24, 2023
Signed-off-by: alexey.makhonin <alexey.makhonin@flant.com>
@deckhouse-BOaTswain
Copy link
Collaborator

Cherry pick PR 4757 to the branch release-1.46 successful!

deckhouse-BOaTswain added a commit that referenced this pull request May 24, 2023
Signed-off-by: alexey.makhonin <alexey.makhonin@flant.com>
Co-authored-by: Makhonin Alexey <60808275+alex123012@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants