[deckhouse] Add prometheus.deckhouse.io/rules-watcher-enabled on d8-system namespace
#4752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-system namespace Signed-off-by: Nikolay Mitrofanov <nikolay.mitrofanov@flant.com>
name212
changed the title
prometheus.deckhouse.io/rules-watcher-enabled on d8…prometheus.deckhouse.io/rules-watcher-enabled on d8-system namespace
name212
added
skip/e2e
yalosev
approved these changes
May 24, 2023
github-actions bot
pushed a commit
that referenced
this pull request
May 25, 2023
…-system namespace (#4752) Signed-off-by: Nikolay Mitrofanov <nikolay.mitrofanov@flant.com>
|
Cherry pick PR 4760 to the branch release-1.46 successful! |
This was referenced May 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add prometheus.deckhouse.io/rules-watcher-enabled on d8-system namespace.
We should set label to all namespaces with prometheus rules (see related pr).
But we forget to add label to
d8-systemnamespace because we do not have manifest for it. d8-system ns was created by dhctl.Why do we need it, and what problem does it solve?
Prometheus rules from d8-system can not be found.
Why do we need it in the patch release (if we do)?
Prometheus rules from d8-system can not be found.
What is the expected result?
Checklist
Changelog entries