Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deckhouse] Add alert for invalid config #493

Merged
merged 1 commit into from Dec 24, 2021
Merged

[deckhouse] Add alert for invalid config #493

merged 1 commit into from Dec 24, 2021

Conversation

yalosev
Copy link
Member

@yalosev yalosev commented Dec 24, 2021 •
edited

(Close #87)

Description

Fix time interval

Why do we need it, and what problem does it solve?

Hardcoded time interval was too short. Use ScrapeInterval x2 instead

Changelog entries

module: deckhouse
type: fix 
description: Use scrape interval x2 instead of hardcoded value for invalid config values alerting

@yalosev yalosev self-assigned this Dec 24, 2021
@yalosev yalosev force-pushed the deckhouse-config-values-alert branch from 7ac89fe to da13ee9 Compare December 24, 2021 12:09
@yalosev yalosev marked this pull request as ready for review December 24, 2021 12:26
@nabokihms nabokihms added this to the v1.30.0 milestone Dec 24, 2021
@nabokihms nabokihms merged commit 6fa4b82 into main Dec 24, 2021
@nabokihms nabokihms deleted the deckhouse-config-values-alert branch December 24, 2021 12:55
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Dec 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabokihms nabokihms nabokihms approved these changes

Assignees

@yalosev yalosev

Labels
None yet
Projects
None yet
Milestone
v1.30.0
Development

Successfully merging this pull request may close these issues.

[deckhouse] alert if config validation fails
2 participants
@yalosev @nabokihms