Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[local-path-provisioner] add reclaimPolicy field. #561

Merged
merged 1 commit into from Jan 26, 2022
Merged

[local-path-provisioner] add reclaimPolicy field. #561

merged 1 commit into from Jan 26, 2022

Conversation

RomanenkoDenys
Copy link
Member

@RomanenkoDenys RomanenkoDenys commented Jan 11, 2022 •
edited by konstantin-axenov

Description

  1. Added reclaimPolicy selector.
  2. Changed default reclaimPolicy from Delete to Retain.

Why do we need it, and what problem does it solve?

Users asks us to have ability to set reclaim policy for local-path-provisioner volumes.

Changelog entries

module: local-path-provisioner
type: feature
description: "Added reclaimPolicy selector, set default reclaimPolicy to Retain"

@RomanenkoDenys RomanenkoDenys changed the title Draft: [local-path-provisioner] add reclaimPolicy field. [local-path-provisioner] add reclaimPolicy field. Jan 14, 2022
@konstantin-axenov konstantin-axenov linked an issue Jan 14, 2022 that may be closed by this pull request
LocalPathProvisioner: Retain retention policy #360
Closed
2 tasks
@RomanenkoDenys RomanenkoDenys force-pushed the lpp-retention branch 2 times, most recently from 23c7dbf to a48a6c6 Compare January 14, 2022 12:57
nabokihms
nabokihms approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@nabokihms nabokihms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in advance, but please fill in the description template.

@konstantin-axenov konstantin-axenov added this to the v1.30.0 milestone Jan 26, 2022
@konstantin-axenov konstantin-axenov merged commit f130872 into main Jan 26, 2022
@konstantin-axenov konstantin-axenov deleted the lpp-retention branch January 26, 2022 14:05
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Jan 26, 2022
Merged
@z9r5
Copy link
Member

z9r5 commented Jan 26, 2022

Cherry-picked into release-1.30

@z9r5 z9r5 removed the status/backport Backport pr label Jan 26, 2022
@nabokihms nabokihms mentioned this pull request Jan 29, 2022
Closed
@RomanenkoDenys RomanenkoDenys mentioned this pull request Feb 7, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabokihms nabokihms nabokihms approved these changes

Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
v1.30.0
Development

Successfully merging this pull request may close these issues.

LocalPathProvisioner: Retain retention policy
5 participants
@RomanenkoDenys @z9r5 @nabokihms @konstantin-axenov @mac2000