Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node-manager][bashible-apiserver] Fix: no context for node groups in static cluster #571

Merged
merged 1 commit into from Jan 12, 2022

Conversation

name212
Copy link
Member

@name212 name212 commented Jan 12, 2022

Description

If cloud provider does not present in bashible-apiserver input context will not return error for calculating checksum.

In dhctl, first will check deckhouse pod is ready and then will get and print log. It needs for add master node group. Without master node group we can get case in which control-plane manager change kublet tls settings, and dhctl cannot get logs, because kubelet certificate is become not valid.

Deleted test_data dir with context render test.

Why do we need it, and what problem does it solve?

Static cluster does not bootstrap.

Changelog entries

module: bashible-apiserver
type: fix
description: Fix do not render bashible bundle in static clusters .
module: dhctl
type: fix
description: Check deckhouse pod readiness before get logs. It fixes static cluster bootstrap.

@name212 name212 force-pushed the nm-fix-bashible-apiserver-context-for-static branch from 5c7f1cf to e6c0817 Compare January 12, 2022 15:46
@name212 name212 self-assigned this Jan 12, 2022
@name212 name212 force-pushed the nm-fix-bashible-apiserver-context-for-static branch from 04f235d to ec65827 Compare January 12, 2022 18:21
@name212 name212 requested a review from yalosev January 12, 2022 18:38
@name212 name212 added area/cli Pull requests that update cli area/cluster-and-infrastructure Pull requests that update infra modules type/bug labels Jan 12, 2022
@name212 name212 marked this pull request as ready for review January 12, 2022 18:40
@name212 name212 added the status/backport Backport pr label Jan 12, 2022
Copy link
Member

@yalosev yalosev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabokihms nabokihms merged commit a54961e into main Jan 12, 2022
@nabokihms nabokihms deleted the nm-fix-bashible-apiserver-context-for-static branch January 12, 2022 21:08
@z9r5 z9r5 added this to the v1.30.0 milestone Jan 13, 2022
@z9r5 z9r5 removed the status/backport Backport pr label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Pull requests that update cli area/cluster-and-infrastructure Pull requests that update infra modules type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants