Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[node-manager] update nodeUser resource #595

Merged
merged 1 commit into from
Jan 25, 2022
Merged

[node-manager] update nodeUser resource #595

merged 1 commit into from
Jan 25, 2022

Conversation

RomanenkoDenys
Copy link
Member

@RomanenkoDenys RomanenkoDenys commented Jan 16, 2022 •
edited by konstantin-axenov

Description

This PR adds:

  1. Support of node-group selector for node-users.
  2. Support of multiple ssh keys per user.
  3. Immediate change of corresponding system user, if nodeuser crd is changed.

Why do we need it, and what problem does it solve?

Changelog entries

module: node-manager
type: feature
description: "Update NodeUser resource to support NodeGroup selector and multiple ssh keys."
note:

@RomanenkoDenys RomanenkoDenys self-assigned this Jan 16, 2022
@EvgenySamoylov
Copy link
Contributor

Closes #107 and #85

yalosev
yalosev previously approved these changes Jan 24, 2022
View reviewed changes
@nabokihms nabokihms added this to the v1.31.0 milestone Jan 25, 2022
@nabokihms nabokihms merged commit 486ff94 into main Jan 25, 2022
@nabokihms nabokihms deleted the nodeuser-v2 branch January 25, 2022 20:38
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Jan 25, 2022
Merged
@konstantin-axenov konstantin-axenov modified the milestones: v1.31.0, v1.30.6 Feb 1, 2022
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Feb 1, 2022
Merged
This was referenced Feb 7, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabokihms nabokihms nabokihms approved these changes

@yalosev yalosev yalosev left review comments

@konstantin-axenov konstantin-axenov Awaiting requested review from konstantin-axenov konstantin-axenov is a code owner

Assignees

@RomanenkoDenys RomanenkoDenys

Labels
type/enhancement
Projects
None yet
Milestone
v1.30.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@RomanenkoDenys @EvgenySamoylov @yalosev @nabokihms @konstantin-axenov