Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[user-authn] Return 401 instead of 200 if a password authentication attempt failed #6045

Merged
merged 1 commit into from
Oct 9, 2023
Merged

[user-authn] Return 401 instead of 200 if a password authentication attempt failed #6045

merged 1 commit into from
Oct 9, 2023

Conversation

nabokihms
Copy link
Member

@nabokihms nabokihms commented Oct 4, 2023 •
edited

Why do we need it, and what problem does it solve?

dexidp/dex#2796

Why do we need it in the patch release (if we do)?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: user-authn
type: fix
summary: Return 401 instead of 200 if a password authentication attempt failed.

@nabokihms
[user-authn] Return 401 instead of 200 if a password authentication a…
5a0f4a3 
…ttempt failed

Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
@github-actions github-actions bot added the area/auth Pull requests that update auth modules label Oct 4, 2023
@nabokihms nabokihms added this to the v1.53.0 milestone Oct 4, 2023
@nabokihms nabokihms marked this pull request as ready for review October 6, 2023 10:54
RomanenkoDenys
RomanenkoDenys approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@RomanenkoDenys RomanenkoDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RomanenkoDenys RomanenkoDenys merged commit c114657 into main Oct 9, 2023
32 of 34 checks passed
@RomanenkoDenys RomanenkoDenys deleted the user-authn-401-passowrd-auth branch October 9, 2023 07:11
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Oct 9, 2023
Merged
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Oct 22, 2023
Merged
@konstantin-axenov konstantin-axenov mentioned this pull request Nov 9, 2023
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanenkoDenys RomanenkoDenys RomanenkoDenys approved these changes

Assignees

@nabokihms nabokihms

Labels
area/auth Pull requests that update auth modules
Projects
None yet
Milestone
v1.53.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nabokihms @RomanenkoDenys