Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] Add monitoring linter #638

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Conversation

nabokihms
Copy link
Member

Signed-off-by: m.nabokikh maksim.nabokikh@flant.com

Description

  • Move clause to deploy Prometheus CRDs to the helm_lib code
  • Refactor monitroing.yaml files
  • Add linter

Why do we need it, and what problem does it solve?

We need this linter to not forget to add enable monitoring if there are dashboards and alert rules. The content of the trigger file is predictable, so we can also validate it to avoid logical mistakes.

Changelog entries

module: testing
type: feature
description: Add monitoring trigger linter for modules

@nabokihms nabokihms added the area/testing Pull requests that update testing code label Jan 21, 2022
@nabokihms nabokihms self-assigned this Jan 21, 2022
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Pull requests that update testing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants