Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[testing] Matrix tests speedup #644

Merged
merged 2 commits into from
Jan 31, 2022
Merged

[testing] Matrix tests speedup #644

merged 2 commits into from
Jan 31, 2022

Conversation

nabokihms
Copy link
Member

@nabokihms nabokihms commented Jan 24, 2022 •
edited

Signed-off-by: m.nabokikh maksim.nabokikh@flant.com

Why do we need it, and what problem does it solve?

According to profiling results, some of the helm template functions generate garbage, overloading the garbage collector.

Changelog entries

module: testing
type: feature
description: Speed up matrix tests, reduce object allocations for helm renders

@nabokihms nabokihms added the skip/documentation-validation Skip documentation validation in pull request label Jan 24, 2022
@nabokihms nabokihms force-pushed the speedup-matrix-tests branch 2 times, most recently from f9c6053 to 5884ea5 Compare January 24, 2022 23:20
@nabokihms nabokihms self-assigned this Jan 24, 2022
@nabokihms nabokihms marked this pull request as ready for review January 24, 2022 23:30
@konstantin-axenov konstantin-axenov added this to the v1.31.0 milestone Jan 26, 2022
@konstantin-axenov konstantin-axenov added the area/testing Pull requests that update testing code label Jan 26, 2022
@nabokihms nabokihms force-pushed the speedup-matrix-tests branch 2 times, most recently from 6e541e7 to df532c3 Compare January 26, 2022 07:43
@nabokihms
[testing] Matrix tests speedup
6cc2d60 
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
@nabokihms
[testing] Fix https values
c8b628e 
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
@nabokihms nabokihms merged commit fd57c20 into main Jan 31, 2022
@nabokihms nabokihms deleted the speedup-matrix-tests branch January 31, 2022 08:07
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Jan 31, 2022
Merged
@konstantin-axenov konstantin-axenov modified the milestones: v1.31.0, v1.30.6 Feb 1, 2022
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konstantin-axenov konstantin-axenov konstantin-axenov left review comments

Assignees

@nabokihms nabokihms

Labels
area/testing Pull requests that update testing code skip/documentation-validation Skip documentation validation in pull request
Projects
None yet
Milestone
v1.30.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nabokihms @konstantin-axenov