Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] remove extra semver lib #664

Merged
merged 1 commit into from
Jan 26, 2022
Merged

[chore] remove extra semver lib #664

merged 1 commit into from
Jan 26, 2022

Conversation

yalosev
Copy link
Member

@yalosev yalosev commented Jan 25, 2022

Description

Remove extra semver lib usage

Why do we need it, and what problem does it solve?

We use 2 semver libs, from Mastermind and Blang. They have a bit different behavior in some cases, so we decided to left only Mastermind library to avoid bugs.

Changelog entries

module: chore
type: fix
description: Remove extra semver lib

@yalosev yalosev self-assigned this Jan 25, 2022
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Jan 25, 2022

Run workflow "e2e/run/openstack"...
⏩ Workflow e2e: OpenStack, Containerd, k8s 1.21 for refs/heads/main started.

🔴 e2e: OpenStack, Kubernetes 1.21 failed.

@github-actions github-actions bot removed the e2e/run/openstack Run e2e tests in OpenStack label Jan 25, 2022
@yalosev yalosev added the e2e/run/openstack Run e2e tests in OpenStack label Jan 25, 2022
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Jan 25, 2022

Run workflow "e2e/run/openstack"...
⏩ Workflow e2e: OpenStack, Containerd, k8s 1.21 for refs/heads/main started.

🔴 e2e: OpenStack, Kubernetes 1.21 failed.

@github-actions github-actions bot removed the e2e/run/openstack Run e2e tests in OpenStack label Jan 25, 2022
@yalosev yalosev marked this pull request as ready for review January 26, 2022 07:29
@nabokihms nabokihms added this to the v1.31.0 milestone Jan 26, 2022
@nabokihms nabokihms merged commit e7ffd79 into main Jan 26, 2022
@nabokihms nabokihms deleted the semver-lib-fix branch January 26, 2022 09:49
@konstantin-axenov konstantin-axenov modified the milestones: v1.31.0, v1.30.6 Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants