Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[validators] handle export validator case with pointer #682

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

yalosev
Copy link
Member

@yalosev yalosev commented Jan 27, 2022

Signed-off-by: Yuriy Losev yuriy.losev@flant.com

Description

Export struct validator skips structs called like n := &Struct{} or n := new(Struct)

Why do we need it, and what problem does it solve?

We check FilterResult with unexported fields and such kind of declaration is out of the validator scope

Changelog entries

module: testing
type: fix
description: Fix export struct validator corner case

@yalosev yalosev self-assigned this Jan 27, 2022
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
@nabokihms nabokihms added the area/testing Pull requests that update testing code label Jan 27, 2022
@nabokihms nabokihms added this to the v1.31.0 milestone Jan 27, 2022
@nabokihms nabokihms merged commit d4d9e73 into main Jan 27, 2022
@nabokihms nabokihms deleted the export-validator-case branch January 27, 2022 12:25
@konstantin-axenov konstantin-axenov modified the milestones: v1.31.0, v1.30.6 Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Pull requests that update testing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants