Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[terraform-manager] fix a binary name for terraform-provider-google plugin #7156

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

aleksey-su
Copy link
Member

@aleksey-su aleksey-su commented Jan 16, 2024

Description

Rename plugin terraform-provider-gcp to terraform-provider-google in terraform-state-exporter.

Why do we need it, and what problem does it solve?

Solved an issue with error "Validating provider hashicorp/google v3.48.0 failed: provider binary not
found: could not find executable file starting with terraform-provider-google"

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: terraform-manager
type: fix
summary: Rename plugin `terraform-provider-gcp` to `terraform-provider-google` in `terraform-state-exporter`.
impact_level: default

Signed-off-by: Alexey Sulimenko <alexey.sulimenko@flant.com>
@aleksey-su aleksey-su added this to the v1.58.0 milestone Jan 16, 2024
@aleksey-su aleksey-su added the e2e/run/gcp Run e2e tests in Google Cloud label Jan 16, 2024
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Jan 16, 2024

🟢 e2e: GCP for deckhouse:terraform-provider-gcp_incorrect_name succeeded in 27m45s.

Workflow details

GCP-WithoutNAT-Containerd-1.25 - Connection string: ssh user@34.159.45.205

🟢 e2e: GCP, Containerd, Kubernetes 1.25 succeeded in 27m10s.

@github-actions github-actions bot removed the e2e/run/gcp Run e2e tests in Google Cloud label Jan 16, 2024
@aleksey-su aleksey-su self-assigned this Jan 16, 2024
@aleksey-su aleksey-su added the e2e/run/gcp Run e2e tests in Google Cloud label Jan 16, 2024
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Jan 16, 2024

🟢 e2e: GCP for deckhouse:terraform-provider-gcp_incorrect_name succeeded in 29m38s.

Workflow details

GCP-WithoutNAT-Containerd-1.25 - Connection string: ssh user@34.107.12.132

🟢 e2e: GCP, Containerd, Kubernetes 1.25 succeeded in 28m59s.

@github-actions github-actions bot removed the e2e/run/gcp Run e2e tests in Google Cloud label Jan 16, 2024
…lugin

Signed-off-by: Alexey Sulimenko <alexey.sulimenko@flant.com>
@github-actions github-actions bot added area/cloud-provider Pull requests that update cloud providers modules area/cluster-and-infrastructure Pull requests that update infra modules labels Jan 16, 2024
@aleksey-su aleksey-su changed the title fix [terraform-manager] fix a binary name for terraform-provider-google plugin Jan 16, 2024
@aleksey-su aleksey-su added the e2e/run/gcp Run e2e tests in Google Cloud label Jan 16, 2024
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Jan 16, 2024

🟢 e2e: GCP for deckhouse:terraform-provider-gcp_incorrect_name succeeded in 32m2s.

Workflow details

GCP-WithoutNAT-Containerd-1.25 - Connection string: ssh user@34.159.45.205

🟢 e2e: GCP, Containerd, Kubernetes 1.25 succeeded in 31m22s.

@github-actions github-actions bot removed the e2e/run/gcp Run e2e tests in Google Cloud label Jan 16, 2024
@aleksey-su
Copy link
Member Author

root@a7542934083-1-con-1-25-master-0:~# kubectl -n d8-system exec -it deploy/terraform-state-exporter -- dhctl terraform check --kube-client-from-cluster
Defaulted container "exporter" out of: exporter, kube-rbac-proxy
Check started ...

┌ 🎈 ~ Common: Connect to Kubernetes API
│ ┌ Get Kubernetes API client
│ │ 🎉 Succeeded!
│ └ Get Kubernetes API client (0.00 seconds)
│
│ ┌ Waiting for Kubernetes API to become Ready
│ │ 🎉 Succeeded!
│ └ Waiting for Kubernetes API to become Ready (0.01 seconds)
└ 🎈 ~ Common: Connect to Kubernetes API (0.06 seconds)

❗ ~ Modules dir not foundGet Cluster UUID from the Kubernetes cluster
│ 🎉 Succeeded!
└ Get Cluster UUID from the Kubernetes cluster (0.00 seconds)

┌ Get Cluster Terraform state from Kubernetes cluster
│ 🎉 Succeeded!
└ Get Cluster Terraform state from Kubernetes cluster (0.00 seconds)

┌ 🌱 ~ Terraform: Check state base-infrastructure for Kubernetes cluster
│ ┌ terraform init ...
│ │ Initializing modules...
│ │
│ │ Initializing the backend...
│ │
│ │ Initializing provider plugins...
│ │ - Using previously-installed hashicorp/google v3.48.0
│ │
│ │ The following providers do not have any version constraints in configuration,
│ │ so the latest version was installed.
│ │
│ │ To prevent automatic upgrades to new major versions that may contain breaking
│ │ changes, we recommend adding version constraints in a required_providers block
│ │ in your configuration, with the constraint strings suggested below.
│ │
│ │ * hashicorp/google: version = "~> 3.48.0"
│ │
│ │ Terraform has been successfully initialized!
│ │ Terraform runner "base-infrastructure" process exited.
│ └ terraform init ... (0.36 seconds)
│
│ ┌ terraform plan ...
│ │ Refreshing Terraform state in-memory prior to plan...
│ │ The refreshed state will be used to calculate this plan, but will not be
│ │ persisted to local or remote state storage.
│ │
│ │ data.google_compute_zones.available: Refreshing state... [id=projects/d8-tests/regions/europe-west3]
│ │ google_compute_network.kube: Refreshing state... [id=projects/d8-tests/global/networks/a7542934083-1-con-1-25]
│ │ google_compute_subnetwork.kube: Refreshing state... [id=projects/d8-tests/regions/europe-west3/subnetworks/a7542934083-1-con-1-25]
│ │ module.firewall.google_compute_firewall.ssh-and-icmp: Refreshing state...                                                              ↵
│ │ [id=projects/d8-tests/global/firewalls/a7542934083-1-con-1-25-ssh-and-ping]
│ │ module.firewall.google_compute_firewall.intercommunication: Refreshing state...                                                        ↵
│ │ [id=projects/d8-tests/global/firewalls/a7542934083-1-con-1-25-intercommunication]
│ │
│ │ ------------------------------------------------------------------------
│ │
│ │ No changes. Infrastructure is up-to-date.
│ │
│ │ This means that Terraform did not detect any differences between your
│ │ configuration and real physical resources that exist. As a result, no
│ │ actions need to be performed.
│ │ Terraform runner "base-infrastructure" process exited.
│ └ terraform plan ... (1.78 seconds)
└ 🌱 ~ Terraform: Check state base-infrastructure for Kubernetes cluster (2.88 seconds)

┌ Get Nodes Terraform state from Kubernetes cluster
│ nodeGroup=master nodeName=a7542934083-1-con-1-25-master-0 symbols=10139
│ 🎉 Succeeded!
└ Get Nodes Terraform state from Kubernetes cluster (0.03 seconds)

┌ Get NodeGroups node template settings
│ 🎉 Succeeded!
└ Get NodeGroups node template settings (0.00 seconds)

┌ 🌱 ~ Terraform: Check state master-node for a7542934083-1-con-1-25-master-0
│ ┌ terraform init ...
│ │
│ │ Initializing the backend...
│ │
│ │ Initializing provider plugins...
│ │ - Using previously-installed hashicorp/google v3.48.0
│ │
│ │ The following providers do not have any version constraints in configuration,
│ │ so the latest version was installed.
│ │
│ │ To prevent automatic upgrades to new major versions that may contain breaking
│ │ changes, we recommend adding version constraints in a required_providers block
│ │ in your configuration, with the constraint strings suggested below.
│ │
│ │ * hashicorp/google: version = "~> 3.48.0"
│ │
│ │ Terraform has been successfully initialized!
│ │ Terraform runner "master-node" process exited.
│ └ terraform init ... (0.38 seconds)
│
│ ┌ terraform plan ...
│ │ Refreshing Terraform state in-memory prior to plan...
│ │ The refreshed state will be used to calculate this plan, but will not be
│ │ persisted to local or remote state storage.
│ │
│ │ data.google_compute_zones.available: Refreshing state... [id=projects/d8-tests/regions/europe-west3]
│ │ data.google_compute_subnetwork.kube: Refreshing state... [id=projects/d8-tests/regions/europe-west3/subnetworks/a7542934083-1-con-1-25]
│ │ google_compute_address.master[0]: Refreshing state...                                                                                  ↵
│ │ [id=projects/d8-tests/regions/europe-west3/addresses/a7542934083-1-con-1-25-master-0]
│ │ google_compute_disk.kubernetes_data: Refreshing state...                                                                               ↵
│ │ [id=projects/d8-tests/zones/europe-west3-b/disks/a7542934083-1-con-1-25-kubernetes-data-0]
│ │ google_compute_instance.master: Refreshing state...                                                                                    ↵
│ │ [id=projects/d8-tests/zones/europe-west3-b/instances/a7542934083-1-con-1-25-master-0]
│ │
│ │ ------------------------------------------------------------------------
│ │
│ │ No changes. Infrastructure is up-to-date.
│ │
│ │ This means that Terraform did not detect any differences between your
│ │ configuration and real physical resources that exist. As a result, no
│ │ actions need to be performed.
│ │ Terraform runner "master-node" process exited.
│ └ terraform plan ... (1.87 seconds)
└ 🌱 ~ Terraform: Check state master-node for a7542934083-1-con-1-25-master-0 (2.26 seconds)
cluster:
  status: ok
node_templates:
- name: master
  status: ok
nodes:
- group: master
  name: a7542934083-1-con-1-25-master-0
  status: ok

@aleksey-su aleksey-su marked this pull request as ready for review January 16, 2024 14:48
@aleksey-su aleksey-su modified the milestones: v1.58.0, v1.57.0 Jan 16, 2024
@RomanenkoDenys RomanenkoDenys merged commit 35c5186 into main Jan 17, 2024
41 of 42 checks passed
@RomanenkoDenys RomanenkoDenys deleted the terraform-provider-gcp_incorrect_name branch January 17, 2024 10:17
This was referenced Jan 17, 2024
ghostinsoba pushed a commit that referenced this pull request Jan 31, 2024
…lugin (#7156)

Signed-off-by: Alexey Sulimenko <alexey.sulimenko@flant.com>
Signed-off-by: Timur Kamaev <timur.kamaev@flant.com>
pashcovich pushed a commit that referenced this pull request Mar 6, 2024
…lugin (#7156)

Signed-off-by: Alexey Sulimenko <alexey.sulimenko@flant.com>
Horiodino pushed a commit to Horiodino/deckhouse that referenced this pull request Apr 21, 2024
…lugin (deckhouse#7156)

Signed-off-by: Alexey Sulimenko <alexey.sulimenko@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cloud-provider Pull requests that update cloud providers modules area/cluster-and-infrastructure Pull requests that update infra modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants