[node-manager] handle k8s <1.20 in NG error events creation process #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@z9r5 have to backport in 1.30 |
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
yalosev
force-pushed
the
fix-ng-event-creation
branch
from
1a13e7a
to
a25ebfe
Compare
nabokihms
approved these changes
Feb 3, 2022
Merged
|
Cherry-picked into release-1.30 |
z9r5
pushed a commit
that referenced
this pull request
Feb 9, 2022
…757) Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuriy Losev yuriy.losev@flant.com
Description
Fix event creation for kubernetes <= 1.19
Why do we need it, and what problem does it solve?
events.k8s.io/v1API was opened for publicity in k8 1.20, before it was available only for scheduler. K8s tries to convertevents.k8s.io/v1tocore.io/v1but it can't convert events that bind to ClusterScope resources properly.We can figure out a version of the k8s and create an event of the necessary type.
Changelog entries