Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cloud-provider-aws] fix additionalRolePolicies regex #7696

Merged
merged 2 commits into from
Mar 4, 2024
Merged

[cloud-provider-aws] fix additionalRolePolicies regex #7696

merged 2 commits into from
Mar 4, 2024

Conversation

RomanenkoDenys
Copy link
Member

@RomanenkoDenys RomanenkoDenys commented Mar 1, 2024 •
edited by z9r5

Description

Fix additionalRolePolicies regex.

Why do we need it, and what problem does it solve?

Regex was wrong and cannot accept valid roles like kafka-cluster:*Topic*.

Why do we need it in the patch release (if we do)?

There is no need.

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: candi
type: fix
summary: Fix regex validation pattern of the `additionalRolePolicies` field.
impact_level: default

@RomanenkoDenys
[cloud-provider-aws] fix additionalRolePolicies regex
1d61e67 
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
@RomanenkoDenys RomanenkoDenys added area/cluster-and-infrastructure Pull requests that update infra modules status/backport Backport pr labels Mar 1, 2024
@RomanenkoDenys RomanenkoDenys added this to the v1.58.3 milestone Mar 1, 2024
@RomanenkoDenys RomanenkoDenys self-assigned this Mar 1, 2024
@github-actions github-actions bot added area/cloud-provider Pull requests that update cloud providers modules area/api-change Pull requests that api changing labels Mar 1, 2024
@RomanenkoDenys
[cloud-provider-aws] fix additionalRolePolicies regex
91758b1 
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
@RomanenkoDenys RomanenkoDenys added skip/documentation-validation Skip documentation validation in pull request e2e/run/aws Run e2e tests in AWS labels Mar 4, 2024
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Mar 4, 2024 •
edited

🟢 e2e: AWS for deckhouse:fix-aws-policy-regex succeeded in 30m36s.

Workflow details

AWS-WithoutNAT-Containerd-1.25 - Connection string: ssh centos@3.120.11.32

🟢 e2e: AWS, Containerd, Kubernetes 1.25 succeeded in 29m58s.

@github-actions github-actions bot removed the e2e/run/aws Run e2e tests in AWS label Mar 4, 2024
@z9r5 z9r5 merged commit 3a12bf8 into main Mar 4, 2024
41 of 43 checks passed
@z9r5 z9r5 deleted the fix-aws-policy-regex branch March 4, 2024 12:12
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Mar 4, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Mar 4, 2024
@RomanenkoDenys @z9r5
[cloud-provider-aws] fix additionalRolePolicies regex (#7696)
0067d8f 
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
@deckhouse-BOaTswain
Copy link
Collaborator

Cherry pick PR 7711 to the branch release-1.58 successful!

deckhouse-BOaTswain added a commit that referenced this pull request Mar 4, 2024
@deckhouse-BOaTswain @RomanenkoDenys
[cloud-provider-aws] fix additionalRolePolicies regex (#7696) (#7711)
920cf49 
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
Co-authored-by: Denys Romanenko <65756796+RomanenkoDenys@users.noreply.github.com>
@deckhouse-BOaTswain deckhouse-BOaTswain removed the status/backport Backport pr label Mar 4, 2024
This was referenced Mar 4, 2024
Closed
Merged
Merged
pashcovich pushed a commit that referenced this pull request Mar 6, 2024
@RomanenkoDenys @pashcovich
[cloud-provider-aws] fix additionalRolePolicies regex (#7696)
9765d9d 
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
This was referenced Mar 6, 2024
Merged
Closed
This was referenced Mar 7, 2024
Merged
Merged
elenashliaga pushed a commit that referenced this pull request Mar 7, 2024
@RomanenkoDenys @elenashliaga
[cloud-provider-aws] fix additionalRolePolicies regex (#7696)
af16445 
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
Horiodino pushed a commit to Horiodino/deckhouse that referenced this pull request Apr 21, 2024
@RomanenkoDenys @Horiodino
[cloud-provider-aws] fix additionalRolePolicies regex (deckhouse#7696)
6b8bf35 
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z9r5 z9r5 z9r5 approved these changes

@nabokihms nabokihms nabokihms approved these changes

@konstantin-axenov konstantin-axenov Awaiting requested review from konstantin-axenov konstantin-axenov is a code owner

Assignees

@RomanenkoDenys RomanenkoDenys

Labels
area/api-change Pull requests that api changing area/cloud-provider Pull requests that update cloud providers modules area/cluster-and-infrastructure Pull requests that update infra modules skip/documentation-validation Skip documentation validation in pull request
Projects
None yet
Milestone
v1.58.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RomanenkoDenys @deckhouse-BOaTswain @z9r5 @nabokihms