Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dhctl] mirror: avoid mirroring versions that were not yet released #7716

Merged
merged 2 commits into from
Mar 6, 2024
Merged

[dhctl] mirror: avoid mirroring versions that were not yet released #7716

merged 2 commits into from
Mar 6, 2024

Conversation

mvasl
Copy link
Member

@mvasl mvasl commented Mar 4, 2024 •
edited by z9r5

Description

Implemented a check that prevents mirroring of versions newer than version of alpha release channel

Why do we need it, and what problem does it solve?

This fixes incorrect versions selection resulting in mirroring of unreleased artifacts.

Why do we need it in the patch release (if we do)?

This is a bugfix.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: dhctl
type: fix
summary: "Avoid mirroring versions in `dhctl mirror` that were not yet released."
impact_level: default

Maxim Vasilenko added 2 commits March 4, 2024 17:23
[dhctl] mirror: avoid mirroring versions that were never released
1a2b277 
Signed-off-by: Maxim Vasilenko <maksim.vasilenko@flant.com>
[dhctl] mirror: avoid mirroring versions that were never released
388bfcd 
Signed-off-by: Maxim Vasilenko <maksim.vasilenko@flant.com>
@mvasl mvasl added this to the v1.58.3 milestone Mar 4, 2024
@mvasl mvasl self-assigned this Mar 4, 2024
@mvasl mvasl added the skip/e2e Skip running e2e test for pass pull request check label Mar 4, 2024
@github-actions github-actions bot added area/cli Pull requests that update cli go Pull requests that update Go code labels Mar 4, 2024
@mvasl mvasl marked this pull request as ready for review March 4, 2024 14:47
@mvasl mvasl requested a review from name212 as a code owner March 4, 2024 14:47
@z9r5 z9r5 modified the milestones: v1.58.3, v1.58.4 Mar 5, 2024
@mvasl mvasl changed the title [dhctl] mirror: avoid mirroring versions that were were not yet released [dhctl] mirror: avoid mirroring versions that were not yet released Mar 5, 2024
@mvasl
Copy link
Member Author

mvasl commented Mar 5, 2024

image

@name212 name212 merged commit a6fee42 into main Mar 6, 2024
42 of 44 checks passed
@name212 name212 deleted the fix/dhctl-mirror-versions-to-pull branch March 6, 2024 07:02
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Mar 6, 2024
Merged
@z9r5 z9r5 added the status/backport Backport pr label Mar 6, 2024
github-actions bot pushed a commit that referenced this pull request Mar 6, 2024
@mvasl @z9r5
[dhctl] mirror: avoid mirroring versions that were not yet released (#…
3a11fee 
…7716)

Signed-off-by: Maxim Vasilenko <maksim.vasilenko@flant.com>
Co-authored-by: Maxim Vasilenko <maksim.vasilenko@flant.com>
@deckhouse-BOaTswain
Copy link
Collaborator

Cherry pick PR 7733 to the branch release-1.58 successful!

deckhouse-BOaTswain added a commit that referenced this pull request Mar 6, 2024
@deckhouse-BOaTswain @mvasl
[dhctl] mirror: avoid mirroring versions that were not yet released (#…
38a428b 
…7716) (#7733)

Signed-off-by: Maxim Vasilenko <maksim.vasilenko@flant.com>
Co-authored-by: Maxim Vasilenko <5184586+mvasl@users.noreply.github.com>
Co-authored-by: Maxim Vasilenko <maksim.vasilenko@flant.com>
@deckhouse-BOaTswain deckhouse-BOaTswain removed the status/backport Backport pr label Mar 6, 2024
@z9r5 z9r5 modified the milestones: v1.58.4, v1.58.3 Mar 6, 2024
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Mar 6, 2024
Merged
pashcovich pushed a commit that referenced this pull request Mar 6, 2024
@mvasl @pashcovich
[dhctl] mirror: avoid mirroring versions that were not yet released (#…
6a2bef3 
…7716)

Signed-off-by: Maxim Vasilenko <maksim.vasilenko@flant.com>
Co-authored-by: Maxim Vasilenko <maksim.vasilenko@flant.com>
This was referenced Mar 6, 2024
Merged
Closed
Merged
Merged
elenashliaga pushed a commit that referenced this pull request Mar 7, 2024
@mvasl @elenashliaga
[dhctl] mirror: avoid mirroring versions that were not yet released (#…
593e039 
…7716)

Signed-off-by: Maxim Vasilenko <maksim.vasilenko@flant.com>
Co-authored-by: Maxim Vasilenko <maksim.vasilenko@flant.com>
Horiodino pushed a commit to Horiodino/deckhouse that referenced this pull request Apr 21, 2024
@mvasl @Horiodino
[dhctl] mirror: avoid mirroring versions that were not yet released (d…
cf1374d 
…eckhouse#7716)

Signed-off-by: Maxim Vasilenko <maksim.vasilenko@flant.com>
Co-authored-by: Maxim Vasilenko <maksim.vasilenko@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@name212 name212 name212 approved these changes

Assignees

@mvasl mvasl

Labels
area/cli Pull requests that update cli go Pull requests that update Go code skip/e2e Skip running e2e test for pass pull request check
Projects
None yet
Milestone
v1.58.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mvasl @deckhouse-BOaTswain @name212 @z9r5