Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ingress-nginx] fix libs and build #7717

Merged
merged 3 commits into from
Mar 5, 2024
Merged

[ingress-nginx] fix libs and build #7717

merged 3 commits into from
Mar 5, 2024

Conversation

RomanenkoDenys
Copy link
Member

@RomanenkoDenys RomanenkoDenys commented Mar 4, 2024 •
edited by z9r5

Description

Fix missed libs.

Why do we need it in the patch release (if we do)?

The fix is necessary for a patch release, as it fixes important bugs.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: ingress-nginx
type: fix
summary: Fix missed libs.
impact: Ingress controller will restart.
impact_level: high

@RomanenkoDenys
[ingress-nginx] fix libs and build
8c2375c 
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
@RomanenkoDenys RomanenkoDenys added the area/core Pull requests that update core modules label Mar 4, 2024
@RomanenkoDenys RomanenkoDenys added this to the v1.58.3 milestone Mar 4, 2024
@RomanenkoDenys RomanenkoDenys self-assigned this Mar 4, 2024
@github-actions github-actions bot added area/network Pull requests that update cni and network modules and removed area/core Pull requests that update core modules labels Mar 4, 2024
@RomanenkoDenys
[ingress-nginx] fix libs and build
86d95d3 
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
@RomanenkoDenys
+
79014bb 
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
@z9r5 z9r5 added status/backport Backport pr e2e/run/aws Run e2e tests in AWS labels Mar 5, 2024
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Mar 5, 2024 •
edited

⚪ e2e: AWS for deckhouse:fix-ingress-2 cancelled.

Workflow details

@github-actions github-actions bot removed the e2e/run/aws Run e2e tests in AWS label Mar 5, 2024
@z9r5 z9r5 merged commit 7fbb077 into main Mar 5, 2024
45 checks passed
@z9r5 z9r5 deleted the fix-ingress-2 branch March 5, 2024 09:39
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Mar 5, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
@RomanenkoDenys @z9r5
[ingress-nginx] fix libs and build (#7717)
f9e46a5 
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
@deckhouse-BOaTswain
Copy link
Collaborator

Cherry pick PR 7722 to the branch release-1.58 successful!

deckhouse-BOaTswain added a commit that referenced this pull request Mar 5, 2024
@deckhouse-BOaTswain @RomanenkoDenys
[ingress-nginx] fix libs and build (#7717) (#7722)
33cd811 
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
Co-authored-by: Denys Romanenko <65756796+RomanenkoDenys@users.noreply.github.com>
@deckhouse-BOaTswain deckhouse-BOaTswain removed the status/backport Backport pr label Mar 5, 2024
This was referenced Mar 5, 2024
Merged
Merged
pashcovich pushed a commit that referenced this pull request Mar 6, 2024
@RomanenkoDenys @pashcovich
[ingress-nginx] fix libs and build (#7717)
4e114c7 
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
This was referenced Mar 6, 2024
Merged
Closed
Merged
Merged
elenashliaga pushed a commit that referenced this pull request Mar 7, 2024
@RomanenkoDenys @elenashliaga
[ingress-nginx] fix libs and build (#7717)
47a300c 
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
Horiodino pushed a commit to Horiodino/deckhouse that referenced this pull request Apr 21, 2024
@RomanenkoDenys @Horiodino
[ingress-nginx] fix libs and build (deckhouse#7717)
9156dc6 
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miklezzzz miklezzzz miklezzzz approved these changes

@yalosev yalosev Awaiting requested review from yalosev yalosev is a code owner

Assignees

@RomanenkoDenys RomanenkoDenys

Labels
area/network Pull requests that update cni and network modules
Projects
None yet
Milestone
v1.58.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RomanenkoDenys @deckhouse-BOaTswain @miklezzzz @z9r5