Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] change go get -u to go get for build immutability #7726

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

RomanenkoDenys
Copy link
Member

@RomanenkoDenys RomanenkoDenys commented Mar 5, 2024

Description

Change go get -u to go get + go mod tidy for build immutability.

Why do we need it, and what problem does it solve?

When we use go get -u, we are updating dependencies to the latest version, not the preferred version.
This causes problems with the resolv of go packages.

Why do we need it in the patch release (if we do)?

Not necessary

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: operator-trivy
type: fix
summary: Use `go get` instead of `go get -u` to image immutability.
impact_level: default
---
section: local-path-provisioner
type: fix
summary: Use `go get` instead of `go get -u` to image immutability.
impact_level: default
---
section: kube-dns
type: fix
summary: Use `go get` instead of `go get -u` to image immutability.
impact_level: default
---
section: user-authn
type: fix
summary: Use `go get` instead of `go get -u` to image immutability.
impact_level: default
---
section: operator-prometheus
type: fix
summary: Use `go get` instead of `go get -u` to image immutability.
impact_level: default
---
section: prometheus
type: fix
summary: Use `go get` instead of `go get -u` to image immutability.
impact_level: default
---
section: prometheus-metrics-adapter
type: fix
summary: Use `go get` instead of `go get -u` to image immutability.
impact_level: default
---
section: monitoring-kubernetes
type: fix
summary: Use `go get` instead of `go get -u` to image immutability.
impact_level: default
---
section: ingress-nginx
type: fix
summary: Use `go get` instead of `go get -u` to image immutability.
impact_level: default
---
section: loki
type: fix
summary: Use `go get` instead of `go get -u` to image immutability.
impact_level: default

Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
@RomanenkoDenys RomanenkoDenys added area/core Pull requests that update core modules status/backport Backport pr labels Mar 5, 2024
@RomanenkoDenys RomanenkoDenys added this to the v1.58.4 milestone Mar 5, 2024
@RomanenkoDenys RomanenkoDenys self-assigned this Mar 5, 2024
@github-actions github-actions bot added area/monitoring Pull requests that update monitoring modules area/auth Pull requests that update auth modules area/network Pull requests that update cni and network modules area/security Pull requests that update security modules area/cluster-and-infrastructure Pull requests that update infra modules area/storage Pull requests that update cloud providers modules area/logs Pull requests that update logging modules and removed area/core Pull requests that update core modules labels Mar 5, 2024
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
@RomanenkoDenys RomanenkoDenys added the e2e/run/aws Run e2e tests in AWS label Mar 5, 2024
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Mar 5, 2024

🟢 e2e: AWS for deckhouse:fix-build-immutability succeeded in 29m53s.

Workflow details

AWS-WithoutNAT-Containerd-1.25 - Connection string: ssh centos@18.196.167.210

🟢 e2e: AWS, Containerd, Kubernetes 1.25 succeeded in 29m11s.

@github-actions github-actions bot removed the e2e/run/aws Run e2e tests in AWS label Mar 5, 2024
@nabokihms nabokihms merged commit 9465a7e into main Mar 5, 2024
38 of 39 checks passed
@nabokihms nabokihms deleted the fix-build-immutability branch March 5, 2024 12:52
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
@deckhouse-BOaTswain
Copy link
Collaborator

Cherry pick PR 7728 to the branch release-1.58 successful!

deckhouse-BOaTswain added a commit that referenced this pull request Mar 5, 2024
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
Co-authored-by: Denys Romanenko <65756796+RomanenkoDenys@users.noreply.github.com>
@deckhouse-BOaTswain deckhouse-BOaTswain removed the status/backport Backport pr label Mar 5, 2024
@z9r5 z9r5 removed this from the v1.58.4 milestone Mar 5, 2024
@z9r5 z9r5 added this to the v1.58.3 milestone Mar 5, 2024
pashcovich pushed a commit that referenced this pull request Mar 6, 2024
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
elenashliaga pushed a commit that referenced this pull request Mar 7, 2024
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
Horiodino pushed a commit to Horiodino/deckhouse that referenced this pull request Apr 21, 2024
)

Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/auth Pull requests that update auth modules area/cluster-and-infrastructure Pull requests that update infra modules area/logs Pull requests that update logging modules area/monitoring Pull requests that update monitoring modules area/network Pull requests that update cni and network modules area/security Pull requests that update security modules area/storage Pull requests that update cloud providers modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants