-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] change go get -u to go get for build immutability #7726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
RomanenkoDenys
added
area/core
Pull requests that update core modules
status/backport
Backport pr
labels
Mar 5, 2024
RomanenkoDenys
requested review from
nabokihms,
miklezzzz,
yalosev and
name212
as code owners
March 5, 2024 10:31
github-actions
bot
added
area/monitoring
Pull requests that update monitoring modules
area/auth
Pull requests that update auth modules
area/network
Pull requests that update cni and network modules
area/security
Pull requests that update security modules
area/cluster-and-infrastructure
Pull requests that update infra modules
area/storage
Pull requests that update cloud providers modules
area/logs
Pull requests that update logging modules
and removed
area/core
Pull requests that update core modules
labels
Mar 5, 2024
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
🟢 Workflow detailsAWS-WithoutNAT-Containerd-1.25 - Connection string: 🟢 |
nabokihms
approved these changes
Mar 5, 2024
Merged
github-actions bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
Cherry pick PR 7728 to the branch release-1.58 successful! |
Merged
pashcovich
pushed a commit
that referenced
this pull request
Mar 6, 2024
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
This was referenced Mar 6, 2024
Closed
Merged
elenashliaga
pushed a commit
that referenced
this pull request
Mar 7, 2024
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/auth
Pull requests that update auth modules
area/cluster-and-infrastructure
Pull requests that update infra modules
area/logs
Pull requests that update logging modules
area/monitoring
Pull requests that update monitoring modules
area/network
Pull requests that update cni and network modules
area/security
Pull requests that update security modules
area/storage
Pull requests that update cloud providers modules
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change
go get -u
togo get
+go mod tidy
for build immutability.Why do we need it, and what problem does it solve?
When we use
go get -u
, we are updating dependencies to the latest version, not the preferred version.This causes problems with the resolv of go packages.
Why do we need it in the patch release (if we do)?
Not necessary
Checklist
Changelog entries