-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dhctl] Add parameterization for bootstrapped kube-resources #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
name212
added
type/enhancement
area/cluster-and-infrastructure
Pull requests that update infra modules
area/core
Pull requests that update core modules
status/backport
Backport pr
labels
Feb 3, 2022
I think, we can get this PR to previous version. |
Run workflow "e2e/run/openstack"... 🟢 |
nabokihms
requested changes
Feb 4, 2022
name212
force-pushed
the
dhctl-resource_yaml-as-template
branch
from
February 4, 2022 14:09
9cd81b4
to
4ca4d9c
Compare
Run workflow "e2e/run/openstack"... 🟢 |
nabokihms
approved these changes
Feb 7, 2022
Cherry-picked into release-1.30 |
z9r5
pushed a commit
that referenced
this pull request
Feb 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/cluster-and-infrastructure
Pull requests that update infra modules
area/core
Pull requests that update core modules
type/enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add parameterization for bootstrapped resources.
Now, we can template resources for bootstrap with cloud discovery data.
Why do we need it, and what problem does it solve?
We can add YandexInstanceClass for ephemeral nodes by providing the resources.yaml file for executing dhctl.
On executing terraform to create initial resources, we discover subnets ids for all zones. It would be convenient if we could use these subnets in YandexInstanceClass to connect instances to subnets created on a previous step.
Changelog entries