Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dhctl] Add parameterization for bootstrapped kube-resources #776

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

name212
Copy link
Member

@name212 name212 commented Feb 3, 2022

Description

Add parameterization for bootstrapped resources.
Now, we can template resources for bootstrap with cloud discovery data.

Why do we need it, and what problem does it solve?

We can add YandexInstanceClass for ephemeral nodes by providing the resources.yaml file for executing dhctl.

On executing terraform to create initial resources, we discover subnets ids for all zones. It would be convenient if we could use these subnets in YandexInstanceClass to connect instances to subnets created on a previous step.

Changelog entries

module: dhctl
type: feature
description: Add a templating feature for Kubernetes resources сreated by dhctl.

@name212 name212 added type/enhancement area/cluster-and-infrastructure Pull requests that update infra modules area/core Pull requests that update core modules status/backport Backport pr labels Feb 3, 2022
@name212 name212 self-assigned this Feb 3, 2022
@name212
Copy link
Member Author

name212 commented Feb 3, 2022

I think, we can get this PR to previous version.

@name212 name212 added e2e/use/k8s/1.21 e2e/run/openstack Run e2e tests in OpenStack labels Feb 3, 2022
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Feb 3, 2022

Run workflow "e2e/run/openstack"...
⏩ Workflow e2e: OpenStack, Containerd, k8s 1.21 for refs/heads/main started.

🟢 e2e: OpenStack, Kubernetes 1.21 succeed.

@github-actions github-actions bot removed the e2e/run/openstack Run e2e tests in OpenStack label Feb 3, 2022
@name212 name212 marked this pull request as ready for review February 3, 2022 23:34
dhctl/pkg/config/resources.go Outdated Show resolved Hide resolved
dhctl/pkg/app/bootstrap.go Outdated Show resolved Hide resolved
@name212 name212 force-pushed the dhctl-resource_yaml-as-template branch from 9cd81b4 to 4ca4d9c Compare February 4, 2022 14:09
@name212 name212 added the e2e/run/openstack Run e2e tests in OpenStack label Feb 4, 2022
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Feb 4, 2022

Run workflow "e2e/run/openstack"...
⏩ Workflow e2e: OpenStack, Containerd, k8s 1.21 for refs/heads/main started.

🟢 e2e: OpenStack, Kubernetes 1.21 succeed.

@github-actions github-actions bot removed the e2e/run/openstack Run e2e tests in OpenStack label Feb 4, 2022
@nabokihms nabokihms added this to the v1.31.0 milestone Feb 7, 2022
@nabokihms nabokihms merged commit 5152a1a into main Feb 7, 2022
@nabokihms nabokihms deleted the dhctl-resource_yaml-as-template branch February 7, 2022 07:40
@konstantin-axenov konstantin-axenov modified the milestones: v1.31.0, v1.30.9 Feb 9, 2022
@z9r5
Copy link
Member

z9r5 commented Feb 9, 2022

Cherry-picked into release-1.30

@z9r5 z9r5 removed the status/backport Backport pr label Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-and-infrastructure Pull requests that update infra modules area/core Pull requests that update core modules type/enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants