Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deckhouse] enable ha only if clusterIsBootstrapped #8275

Merged
merged 1 commit into from
May 6, 2024

Conversation

miklezzzz
Copy link
Member

@miklezzzz miklezzzz commented Apr 26, 2024

Description

This PR introduces an additional condition for the deckhouse module high availability mode: .Values.global.clusterIsBootstrapped values has to be true.

Why do we need it, and what problem does it solve?

This measure should prevent deckhouse operator from switching to high availability mode when the cluster hasn't got bootstrapped yet, minimizing the impact on the whole bootstrapping process.

Why do we need it in the patch release (if we do)?

It may come in handy as soon as possible.

What is the expected result?

If a cluster hasn't bootstrapped yet, deckhouse operator shouldn't be run in high availability mode.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: deckhouse-controller
type: chore
summary: Enable Deckhouse high availability mode only after the bootstrap process is complete.
impact_level: default

Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
@miklezzzz miklezzzz added this to the v1.59.9 milestone Apr 26, 2024
@miklezzzz miklezzzz self-assigned this Apr 26, 2024
@miklezzzz miklezzzz added the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Apr 26, 2024
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Apr 26, 2024

🔴 e2e: Yandex.Cloud for deckhouse:deckhouse-ha-if-cluster-is-bootstrapped failed in 40m27s.

E2e for yandex-cloud WithoutNAT;containerd;1.25 was failed. Use:
ssh -i ~/.ssh/e2e-id-rsa redos@178.154.201.200 - connect for debugging;

/e2e/abort yandex-cloud;WithoutNAT;containerd;1.25 8847401930 8847401930-1-con-1-25 /sys/deckhouse-oss/install:pr8275 redos@178.154.201.200 - for abort failed cluster

Workflow details (1 job failed)

Yandex.Cloud-WithoutNAT-Containerd-1.25 - Connection string: ssh redos@178.154.201.200

🔴 e2e: Yandex.Cloud, Containerd, Kubernetes 1.25 failed in 39m53s.

@github-actions github-actions bot removed the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Apr 26, 2024
@miklezzzz miklezzzz marked this pull request as ready for review April 26, 2024 11:30
@deckhouse-BOaTswain deckhouse-BOaTswain added the e2e/cluster/failed Pull request contains failed e2e cluster label Apr 26, 2024
@miklezzzz
Copy link
Member Author

/e2e/abort yandex-cloud;WithoutNAT;containerd;1.25 8847401930 8847401930-1-con-1-25 /sys/deckhouse-oss/install:pr8275 redos@178.154.201.200

@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Apr 26, 2024

🟢 destroy cluster: Yandex.Cloud for refs/heads/main succeeded in 4m12s.

Workflow details

🟢 destroy cluster: Yandex.Cloud, Containerd, Kubernetes 1.25 succeeded in 3m47s.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/cluster/failed Pull request contains failed e2e cluster label Apr 26, 2024
@miklezzzz miklezzzz added the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Apr 26, 2024
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Apr 26, 2024

🟢 e2e: Yandex.Cloud for deckhouse:deckhouse-ha-if-cluster-is-bootstrapped succeeded in 36m29s.

Workflow details

Yandex.Cloud-WithoutNAT-Containerd-1.25 - Connection string: ssh redos@178.154.225.92

🟢 e2e: Yandex.Cloud, Containerd, Kubernetes 1.25 succeeded in 35m48s.

@github-actions github-actions bot removed the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Apr 26, 2024
@z9r5 z9r5 added status/backport Backport pr area/core Pull requests that update core modules labels May 6, 2024
@z9r5 z9r5 merged commit 0dc81a1 into main May 6, 2024
66 of 67 checks passed
@z9r5 z9r5 deleted the deckhouse-ha-if-cluster-is-bootstrapped branch May 6, 2024 06:47
github-actions bot pushed a commit that referenced this pull request May 6, 2024
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
@deckhouse-BOaTswain
Copy link
Collaborator

Cherry pick PR 8311 to the branch release-1.59 successful!

deckhouse-BOaTswain added a commit that referenced this pull request May 6, 2024
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
Co-authored-by: Mikhail Scherba <41360396+miklezzzz@users.noreply.github.com>
@deckhouse-BOaTswain deckhouse-BOaTswain removed the status/backport Backport pr label May 6, 2024
sample pushed a commit that referenced this pull request May 8, 2024
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Pull requests that update core modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants