Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flant-integration ] Fix build #8321

Merged
merged 2 commits into from
May 6, 2024
Merged

[flant-integration ] Fix build #8321

merged 2 commits into from
May 6, 2024

Conversation

RomanenkoDenys
Copy link
Member

@RomanenkoDenys RomanenkoDenys commented May 6, 2024

Description

Remove python tests from resulting image.

Why do we need it, and what problem does it solve?

If tests has executable bit than it recognises as hooks by shell-operator and it fails.

Why do we need it in the patch release (if we do)?

Critical bugfix.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: flant-integration
type: fix
summary: Remove python tests from the image.
impact_level: default

Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
@RomanenkoDenys RomanenkoDenys added the area/monitoring Pull requests that update monitoring modules label May 6, 2024
@RomanenkoDenys RomanenkoDenys added this to the v1.59.10 milestone May 6, 2024
@RomanenkoDenys RomanenkoDenys self-assigned this May 6, 2024
@github-actions github-actions bot added python Pull requests that update Python code and removed area/monitoring Pull requests that update monitoring modules labels May 6, 2024
@RomanenkoDenys RomanenkoDenys added the status/backport Backport pr label May 6, 2024
@yalosev yalosev requested review from yalosev and removed request for yalosev May 6, 2024 13:44
@z9r5 z9r5 merged commit 82a684a into main May 6, 2024
48 of 50 checks passed
@z9r5 z9r5 deleted the fix-flant-integration-build branch May 6, 2024 14:26
github-actions bot pushed a commit that referenced this pull request May 6, 2024
* [flant-integration] fix image building

Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>

* [flant-integration] fix image building

Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>

---------

Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
@deckhouse-BOaTswain
Copy link
Collaborator

Cherry pick PR 8323 to the branch release-1.59 successful!

deckhouse-BOaTswain added a commit that referenced this pull request May 6, 2024
* [flant-integration] fix image building



* [flant-integration] fix image building



---------

Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
Co-authored-by: Denys Romanenko <65756796+RomanenkoDenys@users.noreply.github.com>
@deckhouse-BOaTswain deckhouse-BOaTswain removed the status/backport Backport pr label May 6, 2024
sample pushed a commit that referenced this pull request May 8, 2024
* [flant-integration] fix image building

Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>

* [flant-integration] fix image building

Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>

---------

Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants