Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cloud-provider-vcd][discovery] Support multiple VCD API versions #8451

Merged
merged 7 commits into from
May 29, 2024
Merged

[cloud-provider-vcd][discovery] Support multiple VCD API versions #8451

merged 7 commits into from
May 29, 2024

Conversation

asviel
Copy link
Contributor

@asviel asviel commented May 22, 2024 •
edited
Loading

Description

Support multiple VCD API versions.

Why do we need it, and what problem does it solve?

We want to support the online volume expansion, which is available since vcd-csi-driver version 1.6.0, but we need to support an older version of the VCD API (< 37.2), which is not compliant with 1.6.0 vcd-csi-driver.

Compatibility matrix: https://github.com/vmware/cloud-director-named-disk-csi-driver/blob/15142e09f9ac1dfcb4860e3f307d28f092b947de/README.md

Why do we need it in the patch release (if we do)?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: cloud-provider-vcd
type: feature
summary: Support multiple VCD API versions.
impact_level: default

@github-actions github-actions bot added area/cloud-provider Pull requests that update cloud providers modules area/testing Pull requests that update testing code area/cluster-and-infrastructure Pull requests that update infra modules area/core Pull requests that update core modules go Pull requests that update Go code area/api-change Pull requests that api changing labels May 22, 2024
@asviel asviel added this to the v1.60.1 milestone May 22, 2024
@asviel
[cloud-provider-vcd][discovery] Support multiple VCD API versions
9b957da 
Signed-off-by: Yan Zarytovsky <yan.zarytovsky@flant.com>
@asviel
Refactor csi image
1389856 
Signed-off-by: Yan Zarytovsky <yan.zarytovsky@flant.com>
@asviel
Add default to version property
57786f6 
Signed-off-by: Yan Zarytovsky <yan.zarytovsky@flant.com>
@asviel
Fix CI
318ae99 
Signed-off-by: Yan Zarytovsky <yan.zarytovsky@flant.com>
@asviel asviel added the skip/documentation-validation Skip documentation validation in pull request label May 23, 2024
@asviel asviel marked this pull request as ready for review May 23, 2024 09:01
@z9r5 z9r5 added the status/backport Backport pr label May 23, 2024
RomanenkoDenys
RomanenkoDenys requested changes May 24, 2024
View reviewed changes
Copy link
Member

@RomanenkoDenys RomanenkoDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please discuss openapi naming with Maksim

@z9r5 z9r5 modified the milestones: v1.60.1, v1.61.0 May 25, 2024
@z9r5 z9r5 removed the status/backport Backport pr label May 25, 2024
@z9r5
Copy link
Member

z9r5 commented May 25, 2024 •
edited
Loading

Please note: I've changed the milestone to 1.61

@asviel
Rename version properties
98fe7bd 
Signed-off-by: Yan Zarytovsky <yan.zarytovsky@flant.com>
@asviel
Fix example
6702635 
Signed-off-by: Yan Zarytovsky <yan.zarytovsky@flant.com>
@asviel
Fix tests
dd31ea6 
Signed-off-by: Yan Zarytovsky <yan.zarytovsky@flant.com>
@raabdullaev raabdullaev modified the milestones: v1.61.0, v1.60.2 May 29, 2024
@z9r5 z9r5 added the status/backport Backport pr label May 29, 2024
@z9r5
Copy link
Member

z9r5 commented May 29, 2024

Please discuss openapi naming with Maksim

Discussed at a meeting.

@z9r5 z9r5 merged commit 61ea44e into main May 29, 2024
39 of 40 checks passed
@z9r5 z9r5 deleted the vcd-csi branch May 29, 2024 08:34
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request May 29, 2024
Merged
github-actions bot pushed a commit that referenced this pull request May 29, 2024
@asviel @z9r5
[cloud-provider-vcd][discovery] Support multiple VCD API versions (#8451
af90f4e 
)

Signed-off-by: Yan Zarytovsky <yan.zarytovsky@flant.com>
@deckhouse-BOaTswain
Copy link
Collaborator

Cherry pick PR 8527 to the branch release-1.60 successful!

deckhouse-BOaTswain added a commit that referenced this pull request May 29, 2024
@deckhouse-BOaTswain @asviel
[cloud-provider-vcd][discovery] Support multiple VCD API versions (#8451
107797c 
) (#8527)

Signed-off-by: Yan Zarytovsky <yan.zarytovsky@flant.com>
Co-authored-by: Yan Zarytovsky <yan.zarytovsky@flant.com>
@deckhouse-BOaTswain deckhouse-BOaTswain removed the status/backport Backport pr label May 29, 2024
This was referenced May 29, 2024
Merged
Merged
Merged
AndreyPavlovFlant pushed a commit that referenced this pull request May 31, 2024
@asviel @AndreyPavlovFlant
[cloud-provider-vcd][discovery] Support multiple VCD API versions (#8451
5bb6f9c 
)

Signed-off-by: Yan Zarytovsky <yan.zarytovsky@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksey-su aleksey-su aleksey-su approved these changes

@z9r5 z9r5 z9r5 approved these changes

@name212 name212 name212 approved these changes

@RomanenkoDenys RomanenkoDenys RomanenkoDenys approved these changes

@nabokihms nabokihms Awaiting requested review from nabokihms nabokihms is a code owner

@konstantin-axenov konstantin-axenov Awaiting requested review from konstantin-axenov konstantin-axenov is a code owner

@AleksZimin AleksZimin Awaiting requested review from AleksZimin AleksZimin is a code owner

Assignees

@asviel asviel

Labels
area/api-change Pull requests that api changing area/cloud-provider Pull requests that update cloud providers modules area/cluster-and-infrastructure Pull requests that update infra modules area/core Pull requests that update core modules area/testing Pull requests that update testing code go Pull requests that update Go code skip/documentation-validation Skip documentation validation in pull request
Projects
None yet
Milestone
v1.60.2
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@asviel @z9r5 @deckhouse-BOaTswain @aleksey-su @name212 @RomanenkoDenys @raabdullaev