[upmeter] Fix numbers for string fields in yaml for UpmeterHookProbe CR template #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabokihms
approved these changes
Mar 2, 2022
Merged
|
Cherry-picked into release-1.30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upmeter agent ID is generated as a string containing hexadecimal number. It is used as UpmeterHookProbe custom resource name and label value. The manifest for the CR is generated from text YAML template, there the ID is substituted unquoted.
When the ID consists of digits only, it is considered a number. The resulting manifests is rendered invalid on the creation of the CR object. This results in the downtime of "deckhouse/cluster-configuration" probe.
Why do we need it, and what problem does it solve?
Fixes #994 , which is a floating bug.
Changelog entries