Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(kube-api-rewriter): rewrite ownerReferences for Lists #148

Merged

Conversation

diafour
Copy link
Member

@diafour diafour commented Jun 21, 2024

Description

  • Add ResourceOrList tranformer around ownerReferences rewriter.

Why do we need it, and what problem does it solve?

Fix KubeVirt error: "Failure while starting VMI: controllerrevisions.apps "revision-start-vm-NNNN-N" already exists'" when restarting VM

What is the expected result?

  1. Create VM with runPolicy AlwaysOn
  2. Restart virt-controller (scale replicas=0, scale replicas=1)
  3. Restart VM from inside (d8 v console, sudo reboot)
  4. VM should terminate and then start.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

- Fix KubeVirt error: "Failure while starting VMI: controllerrevisions.apps "revision-start-vm-NNNN-N" already exists'" when restarting VM

Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
++ revert changes in resources.go

Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour diafour merged commit 8f67db7 into main Jun 22, 2024
20 of 28 checks passed
@diafour diafour deleted the refactor/kube-api-rewriter/fix-rewrite-owner-references-for-list branch June 22, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants