Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VNDA and Nuvemshop sellers #382

Open
guitavano opened this issue Feb 8, 2024 · 1 comment
Open

Fix VNDA and Nuvemshop sellers #382

guitavano opened this issue Feb 8, 2024 · 1 comment
Labels
linx Linx App nuvemshop vnda VNDA App

Comments

@guitavano
Copy link
Contributor

guitavano commented Feb 8, 2024

Issue Type

Please select the type of issue you are reporting:

  • Feature Request

Description

The functions that generate Offers should return the responsible seller. Currently, in the Nuvemshop, Vnda, and Linx-Impulse integrations, this is being populated with the platform's own name. We need to identify how to retrieve the actual seller.

Steps to Reproduce (for bugs)

Go to function:

  const offers: Offer[] = [{
    "@type": "Offer" as const,
    seller: "VNDA", // PROBLEM HERE
    price,
    priceSpecification,
    inventoryLevel: {
      value: available_quantity,
    },
    availability: available
      ? "https://schema.org/InStock"
      : "https://schema.org/OutOfStock",
  }];

Expected Behavior

Correct seller as we have in VTEX Integration:

const toOffer = (
  { commertialOffer: offer, sellerId, sellerName }: SellerVTEX,
): Offer => ({
  "@type": "Offer",
  price: offer.spotPrice ?? offer.Price,
  seller: sellerId, // CORRECT DYNAMIC VALUE
@Samuel-Brito19
Copy link
Contributor

Hi! Can you provide more information about the issue?

@guitavano guitavano added linx Linx App vnda VNDA App nuvemshop labels Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linx Linx App nuvemshop vnda VNDA App
Projects
None yet
Development

No branches or pull requests

2 participants