Unnecessary duplicated types at Linx commerce App

[viktormarinho]

Linx app types/ contains a lot of duplicated types, we should Merge those

[Samuel-Brito19]

Hi! Can you provide more information about the issue? I'm interest.

[viktormarinho]

@Samuel-Brito19

The Linx app utils/types directory (https://github.com/deco-cx/apps/tree/main/linx/utils/types) currently contains a lot of those JSON.ts files.

What happened here is that i used a tool that can generate typescript types from a JSON object (quicktype.io) to map every return of the Linx APIs.

So, for example, when creating the auctionDetail loader, i started by hitting the Linx Endpoint for auction details, copying the json response, pasting it into Quicktype then copying the generated TS Types to the project, putting it in the auctionDetailJSON.ts file.

The problem here is that a lot of these types were shared between different endpoints, and i ended up having a bunch of duplicated types. I already started deduplicating some of those types, but there's a lot of duplicated ones still. For example, i created the facets.ts file and made it the only Facet interface in the linx types folder:

Before, i had a lot of Facet types. But there are more types that can be merged. For example, this Description type, that really should have another name haha, probably something like LinxMetadata that better reflects it.

I want to merge all of these types, it will make the development a lot easier, specially when writing Linx type transformations to Schema.org, and overall improve the correctness of our code