Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: shortcircuit doesnt works #591

Merged
merged 4 commits into from
Mar 1, 2024
Merged

fix: shortcircuit doesnt works #591

merged 4 commits into from
Mar 1, 2024

Conversation

lui-dias
Copy link
Contributor

@lui-dias lui-dias commented Mar 1, 2024

throw error from shortcircuit could not be detect because of async rendering

mcandeia
mcandeia approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@mcandeia mcandeia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix then shipit

blocks/section.ts Outdated Show resolved Hide resolved
@guitavano guitavano merged commit 592480a into deco-cx:main Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcandeia mcandeia mcandeia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lui-dias @mcandeia @guitavano