Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes before v1 and Section Loader #153

Merged
merged 40 commits into from
Apr 12, 2023
Merged

Conversation

mcandeia
Copy link
Contributor

@mcandeia mcandeia commented Apr 9, 2023

  • A lot of minor fixes regarding block typings
  • Implementing some missing transformations on JSONSchema
  • Fixes overfetching on middleware (the middleware is querying database when running in localhost even when JS or static assets are being fetched)
  • Remove supabase local implementation in favor of refreshing config once per request

@mcandeia mcandeia changed the title Fix/middleware over fetching Minor fixes before v1 and Section Loader Apr 9, 2023
blocks/route.ts Outdated
Comment on lines 69 to 71
url.pathname.startsWith("/_frsh") ||
url.pathname.startsWith("~partytown") ||
url.searchParams.has("__frsh_c")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Extract into a const with a name that explains why this is needed

@mcandeia mcandeia force-pushed the fix/middleware-over-fetching branch 2 times, most recently from ca9f233 to af455d6 Compare April 10, 2023 21:02
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
@mcandeia mcandeia force-pushed the fix/middleware-over-fetching branch from af455d6 to d7b501b Compare April 12, 2023 14:51
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
@mcandeia mcandeia force-pushed the fix/middleware-over-fetching branch from 4576c51 to 31fc31f Compare April 12, 2023 14:54
@mcandeia mcandeia merged commit 21250fa into main Apr 12, 2023
@mcandeia mcandeia deleted the fix/middleware-over-fetching branch April 12, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants